From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 97D5D2A6C for ; Wed, 5 Apr 2017 16:24:59 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id k6so16964245wre.2 for ; Wed, 05 Apr 2017 07:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=GQhaF3hbm03TTvfT4BQIcrlDbgl1/idoxlqFPJRkdKQ=; b=dDFLc0MnIDfBGQ9Tjm8bsr21n2PMfAWOUjZVcOxvqn3UuowTzYZGgBhEyAC/2JRUha ERtW/J9Yx+FfpG01Y+9wMBmo4ijz68FB9rykyKYaXmiic+5oT78l35YTRTURK9aR68BR j8+cd1aCM2F/vrs9qFpSuSj0PtOZ4go5RmZ7z5B2dMhblSxAaFYSEwAkNcK8Q6YQ9WnQ RQAqU66oKmTK8zlgjC5O97VcPOD7SCkiaBEBYxDoOIgC8jp16fXhN66QBNhum1K7xfKO oSkmAol+gRi2B/+gd0kkPrShb+LiW6WR/JP1n2QfyU7LatX7tPERRM6bmwo8jVbczQJ+ kOXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=GQhaF3hbm03TTvfT4BQIcrlDbgl1/idoxlqFPJRkdKQ=; b=XnzEUhK4RvjI0owGM63Rgd5fFVj2r3GvanJl7j5MoLNdT9WBFjRrnzeld9FUCqa4Za IJ1PdutaoMU7lCjoga+G1zEBa6GXx0HDgFAbnqg54SM/Jc3eOqQRe4NEf6XPtodMXQ7p oadk9fU+uPBWp7WwoKxD0rICBKsNe5Qvi8WCa8mpWpEv8Gs7PhYSbNEU/JTNvB5bOA4V raktn16h6lyh+D7TDPJh0roDCBmBcxbmAIbLKZZ82j5YntfPOp0BSJMLIe9l1hsPZpkA X9Lt3xokIWu6TDfXT0VVo+LEB4Cxo1HN/GSz9WsTQi3IZvpfNwVFMRF5FILPI/8IgBQ/ tlcw== X-Gm-Message-State: AFeK/H2fzv4CxluYEQfkcFiL1eyKjvFBGjFLWNieEq68YQ7Dz7XHppHgfRWGxATf0WJY88uM X-Received: by 10.223.160.27 with SMTP id k27mr24585126wrk.106.1491402298956; Wed, 05 Apr 2017 07:24:58 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id y107sm26325115wrc.35.2017.04.05.07.24.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 07:24:58 -0700 (PDT) From: Thomas Monjalon To: Remy Horton , Reshma Pattan Cc: dev@dpdk.org, Harry van Haaren Date: Wed, 05 Apr 2017 16:24:57 +0200 Message-ID: <2528866.SURTCWTgWk@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1490907662-27666-6-git-send-email-remy.horton@intel.com> References: <1490907662-27666-1-git-send-email-remy.horton@intel.com> <1490907662-27666-6-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v14 5/6] lib: added new library for latency stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 14:25:00 -0000 2017-03-30 22:01, Remy Horton: > + /* > + * The jitter is calculated as statistical mean of interpacket > + * delay variation. The "jitter estimate" is computed by taking > + * the absolute values of the ipdv sequence and applying an > + * exponential filter with parameter 1/16 to generate the > + * estimate. i.e J=J+(|D(i-1,i)|-J)/16. Where J is jitter, > + * D(i-1,i) is difference in latency of two consecutive packets > + * i-1 and i. > + * Reference: Calculated as per RFC 5481, sec 4.1, > + * RFC 3393 sec 4.5, RFC 1889 sec. > + */ > + glob_stats->jitter += (abs(prev_latency - latency[i]) > + - glob_stats->jitter)/16; > lib/librte_latencystats/rte_latencystats.c:204:27: fatal error: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value] glob_stats->jitter += (abs(prev_latency - latency[i]) ^ note: use function 'fabsf' instead I am a bit sad to see such error at v14. Do you want I fix it for you?