From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31927A0C56; Thu, 25 Nov 2021 10:27:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0177C40DF5; Thu, 25 Nov 2021 10:27:00 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C9C3640140; Thu, 25 Nov 2021 10:26:58 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2E02C5C013A; Thu, 25 Nov 2021 04:26:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 25 Nov 2021 04:26:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= JRjXdTrsFbb0TQXRQlUIEIGIWa58rk/r4uug/2VsYfw=; b=VVqJZCNoa2Ku5q7m diSV8NyH6KY62FthtSx+e4y8EiAeSuGQ/rKSg5sXIbKQ5mivhTKRgj6tWXXHuIyg o+6ZHv8VksLBB6L4gJel5ptM4JQtDF76VGw//Y+MUQkXQ3cjZoFTRZ5/SY4eKlud tDe0RBYJaPnGsemNPJ8nZTG8QFtlgpjQ5MqYrgjBYH0eciJB7G33P9Ha1uxp3o04 RkcEXYOSG+Qi5nahWUeGjP0hNOPf5efYMyLE1sCZjBFM2G9G/dJWF7NqGPmQANtL OZLP6rkBF9vtIoA2V/d+WMrm06fY01KFki+xEZiVUUrIhhOfqZqMKobDpRZJhEt8 JXlK+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=JRjXdTrsFbb0TQXRQlUIEIGIWa58rk/r4uug/2VsY fw=; b=gbK+zIQrY7vHvh+ZHs9jPZnElVLojmg7Hv5tDoiBjr4kO8IvzJ/sviRgr y8B5M6e3oGf/AzZJv0mB5FfjqUvVXRu075d+OM8PbJqfSuSex4XKTCj/1UDIC2UD ZIi4gcJ/HMXAc557npVkHFM/PtQWHvNbNNb2mAxQcgMjAUQxRr6ywN5yE6ZzWTPq cSe9zeElJ2f/bMPByqqJo4KrEIZUrgPhhnuTKdIQ7c309UplzvYbDl+gKgQ5dGUS 2v7WX74THW4/ubzFEqquUSr8SjsEhOiTltAq0pSfthN9pwyozaluws8bC67uWxrd p94EUA7wUZ4cph1h+/8Ifz5s4Wizg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedtgddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Nov 2021 04:26:57 -0500 (EST) From: Thomas Monjalon To: Matan Azrad , Raslan Darawsheh , Michael Baum Cc: dev@dpdk.org, Viacheslav Ovsiienko , stable@dpdk.org, Lior Margalit , asafp@nvidia.com Subject: Re: [PATCH] common/mlx5: fix error handling in multi-class probe Date: Thu, 25 Nov 2021 10:26:53 +0100 Message-ID: <2529522.a978ps6MBx@thomas> In-Reply-To: <20211124220238.3119860-1-michaelba@nvidia.com> References: <20211124220238.3119860-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/11/2021 23:02, michaelba@nvidia.com: > From: Michael Baum > > The common drivers_probe function calls in a loop to all probe functions > for classes requested by the user. After it manages to probe them all, > it updates this on the device in the "classes_loaded" field. > > If one of them fails, all those probed to it are remove using the > drivers_remove function. However, this function only releases the > classes in the "classes_loaded" field on the given device and misses the > newly probed classes. > > This patch removes the condition from the release function, and ensures > that the caller function sends a more accurate parameter. > > Fixes: 8a41f4deccc3 ("common/mlx5: introduce layer for multiple class drivers") > Cc: stable@dpdk.org > > Signed-off-by: Michael Baum > Acked-by: Matan Azrad How well it has been tested? How critical it is to have in 21.11?