From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 678C6A0524; Wed, 14 Apr 2021 10:13:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E13A51617D6; Wed, 14 Apr 2021 10:13:19 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8E41C1617D2; Wed, 14 Apr 2021 10:13:17 +0200 (CEST) IronPort-SDR: cvWqXXOuP2tTd5kwmQ6JrTrD3svMjn3aNCf+5Fs6R4xZZcraGVeS4lpncsI78jAD14G+c5gpeA FokBatIXNRcw== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="258558280" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="258558280" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 01:13:16 -0700 IronPort-SDR: EQtKyItxv0CO6iPN7oUPROpQhR48PP00pRGZoyJqlYpDxb5cZty0hE0y90Stkm5+BJOE1uSTBX S+tSQYdB2Kew== X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="461084352" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.205.34]) ([10.213.205.34]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 01:13:14 -0700 To: Tianyu Li , Jakub Grajciar Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org References: <20210412082231.1866235-1-tianyu.li@arm.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <252a9754-9d9d-36cf-dd4e-6326e604429d@intel.com> Date: Wed, 14 Apr 2021 09:13:10 +0100 MIME-Version: 1.0 In-Reply-To: <20210412082231.1866235-1-tianyu.li@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/12/2021 9:22 AM, Tianyu Li wrote: > Fix the missing Tx-bps counter for memif zero-copy mode > Before > Rx-pps: 6891450 Rx-bps: 3528438928 > Tx-pps: 6891482 Tx-bps: 0 > After > Throughput (since last show) > Rx-pps: 11157056 Rx-bps: 5712413016 > Tx-pps: 11157056 Tx-bps: 5712413016 > > Fixes: 43b815d88188 ("net/memif: support zero-copy slave") > Cc: stable@dpdk.org > > Signed-off-by: Tianyu Li > --- > drivers/net/memif/rte_eth_memif.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c > index 77c95bcb7..dd2825968 100644 > --- a/drivers/net/memif/rte_eth_memif.c > +++ b/drivers/net/memif/rte_eth_memif.c > @@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq > /* populate descriptor */ > d0 = &ring->desc[slot & mask]; > d0->length = rte_pktmbuf_data_len(mbuf); > + mq->n_bytes += rte_pktmbuf_data_len(mbuf); > /* FIXME: get region index */ > d0->region = 1; > d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) - > Looks good to me, but let's wait Jakub's review for it.