From: Thomas Monjalon <thomas@monjalon.net>
To: jerinj@marvell.com
Cc: dev@dpdk.org, david.marchand@redhat.com,
Adrien Mazarguil <adrien.mazaguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] eal: introduce structure marker typedefs
Date: Tue, 10 Dec 2019 23:46:20 +0100 [thread overview]
Message-ID: <2530549.bTtaOq4tWD@xps> (raw)
In-Reply-To: <20191208113413.2179329-1-jerinj@marvell.com>
08/12/2019 12:34, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and
> a generic marker for a point in a structure.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> lib/librte_eal/common/include/rte_common.h | 12 ++++++++++++
Good idea, thanks.
> +/** Generic marker for a point in a structure. */
I think "a point" may be replaced with "any place" or something else?
> +__extension__ typedef void *RTE_MARKER[0];
Why do we need an extension?
If it is part of C11, we should use RTE_STD_C11 instead.
If it is another reason, we could create another meaningful EAL macro.
next prev parent reply other threads:[~2019-12-10 22:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-08 11:34 jerinj
2019-12-08 11:34 ` [dpdk-dev] [PATCH 2/3] drivers: use structure marker typedef in eal jerinj
2019-12-08 11:34 ` [dpdk-dev] [PATCH 3/3] mbuf: " jerinj
2019-12-10 22:46 ` Thomas Monjalon [this message]
2019-12-19 10:34 ` [dpdk-dev] [PATCH 1/3] eal: introduce structure marker typedefs Jerin Jacob
2019-12-19 11:25 ` [dpdk-dev] [PATCH v2 " jerinj
2019-12-19 11:25 ` [dpdk-dev] [PATCH v2 2/3] drivers: use structure marker typedef in eal jerinj
2019-12-19 11:25 ` [dpdk-dev] [PATCH v2 3/3] mbuf: " jerinj
2019-12-26 16:24 ` Olivier Matz
2020-01-20 21:55 ` Thomas Monjalon
2019-12-20 4:21 ` [dpdk-dev] [PATCH v2 1/3] eal: introduce structure marker typedefs Gavin Hu
2019-12-26 8:15 ` Matan Azrad
2020-01-02 6:27 ` Jerin Jacob
2020-01-02 9:48 ` Matan Azrad
2020-01-16 13:09 ` Jerin Jacob
2020-01-20 20:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2530549.bTtaOq4tWD@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazaguil@6wind.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).