From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 85A2EAFD7
 for <dev@dpdk.org>; Tue, 27 May 2014 12:30:10 +0200 (CEST)
Received: by mail-wi0-f169.google.com with SMTP id hi2so1375777wib.4
 for <dev@dpdk.org>; Tue, 27 May 2014 03:30:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=SZG/CVh0Cy45oCtEp5p+Do1p6KyC1F704GaXgqAz3dA=;
 b=Pezan4/SnLYNq4I/WiSViUdNqhHqwLtis39n7lcX+pzZV6RZ8Gbj68DqiLUnNf+yFi
 4L9cfrfml26g5bmLZ6t1lv1QidvOUREBtL/g44lpAKSRanXt/OFM7SkEcvO7zkEC93S2
 ZlOxX4MUOtXQ1G1dD2w+W3+6XhxNm8Ekvu8E/e59J1rP2JqEQVmfD2gcG0WTGY60zgkj
 uvxbem9C+TGDhO9zPAhTCYu5w0xcIvsxS2bomfE5rV9i00/PoTh3AomfQjEYB8K1BTOR
 gLhXDkqbT6v6N1LyXz0/PU1r0Rx0QssPY57HjH3TGpCDMqF+ExvEzRfwnMGxav9gPqTz
 OPnw==
X-Gm-Message-State: ALoCoQnyaWbj4QvnApRAUyoC2cSuqF4dQJAfIMRhB1fv6Q54dfsxNMwVHkTBVhKVRYBtdthi+LlE
X-Received: by 10.180.160.205 with SMTP id xm13mr36994585wib.13.1401186621293; 
 Tue, 27 May 2014 03:30:21 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id je7sm7227623wic.14.2014.05.27.03.30.20
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 27 May 2014 03:30:20 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Date: Tue, 27 May 2014 12:30:16 +0200
Message-ID: <2531802.9vWkcExQfx@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <53845DC5.3000400@huawei.com>
References: <53845DC5.3000400@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] cpu_layout.py: adjust output format to align
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 May 2014 10:30:10 -0000

Hi,

Your patch doesn't apply correctly.
Could you check it, please?

I have also a comment inlined:

2014-05-27 17:41, Shannon Zhao:
> -               print "\t", core_map[(s,c)],
> +               print core_map[(s,c)],"\t",

Is it possible to fix a minimum alignment of 2 characters?
It could prevent from such alignment problem:

Core 11 [9, 33]         [21, 45] 
Core 12 [10, 34]        [22, 46] 

Thanks
-- 
Thomas