From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4F3AD1B2C2; Mon, 14 May 2018 14:32:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2018 05:32:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,399,1520924400"; d="scan'208";a="49075156" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 14 May 2018 05:32:49 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 14 May 2018 05:32:49 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.235]) by fmsmsx116.amr.corp.intel.com ([169.254.2.100]) with mapi id 14.03.0319.002; Mon, 14 May 2018 05:32:49 -0700 From: "Wiles, Keith" To: Ophir Munk CC: "dev@dpdk.org" , Pascal Mazon , Thomas Monjalon , Olga Shern , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling Thread-Index: AQHT5d6gIv6R+xCsMkOVQ5+3SJ5xKqQvqPAA Date: Mon, 14 May 2018 12:32:48 +0000 Message-ID: <254244E5-F272-4020-A978-FC626795AADD@intel.com> References: <1525682200-21821-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: <1525682200-21821-1-git-send-email-ophirmu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.16.78] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 12:32:52 -0000 DQoNCj4gT24gTWF5IDcsIDIwMTgsIGF0IDM6MzYgQU0sIE9waGlyIE11bmsgPG9waGlybXVAbWVs bGFub3guY29tPiB3cm90ZToNCj4gDQo+IFJ1bm5pbmcgdGVzdHBtZCBjb21tYW5kICJmbG93IGlz b2xhZSA8cG9ydD4gMCIgKGkuZS4gZGlzYWJsaW5nIGZsb3cNCj4gaXNvbGF0aW9uKSBmb2xsb3dl ZCBieSBjb21tYW5kICJmbG93IGlzb2xhdGUgPHBvcnQ+IDEiIChpLmUuIGVuYWJsaW5nDQo+IGZs b3cgaXNvbGF0aW9uKSBtYXkgcmVzdWx0IGluIGEgVEFQIGVycm9yOg0KPiBQTUQ6IEtlcm5lbCBy ZWZ1c2VkIFRDIGZpbHRlciBydWxlIGNyZWF0aW9uICgxNyk6IEZpbGUgZXhpc3RzDQo+IA0KPiBS b290IGNhdXNlIGFuYWx5c2lzOiB3aGVuIGRpc2FibGluZyBmbG93IGlzb2xhdGlvbiB3ZSBrZWVw IHRoZSBsb2NhbA0KPiBydWxlIHRvIHJlZGlyZWN0IHBhY2tldHMgb24gVFggKFRBUF9SRU1PVEVf VFggaW5kZXgpIHdoaWxlIHdlIGFkZCBpdA0KPiBhZ2FpbiB3aGVuIGVuYWJsaW5nIGZsb3cgaXNv bGF0aW9uLiBBcyBhIHJlc3VsdCB0aGlzIHJ1bGUgaXMgYWRkZWQNCj4gdHdvIHRpbWVzIGluIGEg cmF3IHdoaWNoIHJlc3VsdHMgaW4gIkZpbGUgZXhpc3RzIiBlcnJvci4NCg0KL3Jhdy9yb3cNCj4g VGhlIGZpeCBpcyB0byBpZGVudGlmeSB0aGUgIkZpbGUgZXhpc3RzIiBlcnJvciBhbmQgc2lsZW50 bHkgaWdub3JlIGl0Lg0KPiANCj4gQW5vdGhlciBpc3N1ZSBvY2N1cnMgd2hlbiBlbmFibGluZyBp c29sYXRpb24gbW9kZSBzZXZlcmFsIHRpbWVzIGluIGENCj4gcmF3IGluIHdoaWNoIGNhc2UgdGhl IHNhbWUgdGMgcnVsZXMgYXJlIGFkZGVkIGNvbnNlY3V0aXZlbHkgYW5kDQoNCi9yYXcvcm93DQo+ IHJ0ZV9mbG93IHN0cnVjdHMgYXJlIGFkZGVkIHRvIGEgbGlua2VkIGxpc3QgYmVmb3JlIHJlbW92 aW5nIHRoZQ0KPiBwcmV2aW91cyBydGVfZmxvdyBzdHJ1Y3RzLg0KPiBUaGUgZml4IGlzIHRvIGFj dCB1cG9uIGlzb2xhdGlvbiBtb2RlIGNvbW1hbmQgb25seSB3aGVuIHRoZXJlIGlzIGENCj4gY2hh bmdlIGZyb20gIjAiIHRvICIxIiAob3IgdmljZSB2ZXJzYSkuDQo+IA0KPiBGaXhlczogZjUwM2Qy Njk0ODI1ICgibmV0L3RhcDogc3VwcG9ydCBmbG93IEFQSSBpc29sYXRlZCBtb2RlIikNCj4gQ2M6 IHN0YWJsZUBkcGRrLm9yZw0KPiANCj4gU2lnbmVkLW9mZi1ieTogT3BoaXIgTXVuayA8b3BoaXJt dUBtZWxsYW5veC5jb20+DQo+IC0tLQ0KPiBkcml2ZXJzL25ldC90YXAvdGFwX2Zsb3cuYyB8IDM3 ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0NCj4gMSBmaWxlIGNoYW5nZWQs IDIzIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbmV0L3RhcC90YXBfZmxvdy5jIGIvZHJpdmVycy9uZXQvdGFwL3RhcF9mbG93LmMNCj4g aW5kZXggYWFiOWVlZi4uOTFmMTVmNiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQvdGFwL3Rh cF9mbG93LmMNCj4gKysrIGIvZHJpdmVycy9uZXQvdGFwL3RhcF9mbG93LmMNCj4gQEAgLTE1Njgs MTAgKzE1NjgsMTAgQEAgdGFwX2Zsb3dfaXNvbGF0ZShzdHJ1Y3QgcnRlX2V0aF9kZXYgKmRldiwN Cj4gew0KPiAJc3RydWN0IHBtZF9pbnRlcm5hbHMgKnBtZCA9IGRldi0+ZGF0YS0+ZGV2X3ByaXZh dGU7DQo+IA0KPiAtCWlmIChzZXQpDQo+IC0JCXBtZC0+Zmxvd19pc29sYXRlID0gMTsNCj4gLQll bHNlDQo+IC0JCXBtZC0+Zmxvd19pc29sYXRlID0gMDsNCj4gKwkvKiBpZiBhbHJlYWR5IGluIHRo ZSByaWdodCBpc29sYXRpb24gbW9kZSAtIG5vdGhpbmcgdG8gZG8gKi8NCj4gKwlpZiAoKCEhc2V0 IF4gcG1kLT5mbG93X2lzb2xhdGUpID09IDApDQo+ICsJCXJldHVybiAwOw0KPiArCXBtZC0+Zmxv d19pc29sYXRlID0gISFzZXQ7DQoNClVzaW5nIGRvdWJsZSBuZWdhdGlvbiBpcyBub3QgdmVyeSBy ZWFkYWJsZSBJTU8sIEkgd291bGQgcHJlZmVyIHRoaXMgY29udmVydGVkIHRvIGEgdHJ1ZSBib29s ZWFuIHR5cGUgaWYgcmVxdWlyZWQuDQoNCnZhcmlhYmxlIOKAmHNldCcgaGVyZSBzaG91bGQgYSAw IG9yIDEgYWxyZWFkeSwgcGxlYXNlIGV4cGFuZCB0aGlzIGNvZGUgdG8gbm90IHVzZSAhISwgdXNp bmcgdGhpcyBpbiBtb2Rlcm4gY29tcGlsZXJzIHNob3VsZCBub3QgYmUgcmVxdWlyZWQuIEkgdW5k ZXJzdGFuZCB0aGlzIG1heWJlIHNob3J0ZWQgdG8gd3JpdGUsIGJ1dCBub3QgdmVyeSByZWFkYWJs ZSBJTU8gYW5kIHdlIG5lZWQgdG8gbWFrZSBEUERLIHJlYWRhYmxlLg0KDQo+IAkvKg0KPiAJICog SWYgbmV0ZGV2aWNlIGlzIHRoZXJlLCBzZXR1cCBhcHByb3ByaWF0ZSBmbG93IHJ1bGVzIGltbWVk aWF0ZWx5Lg0KPiAJICogT3RoZXJ3aXNlIGl0IHdpbGwgYmUgc2V0IHdoZW4gYnJpbmdpbmcgdXAg dGhlIG5ldGRldmljZSAodHVuX2FsbG9jKS4NCj4gQEAgLTE1NzksMjEgKzE1NzksMzAgQEAgdGFw X2Zsb3dfaXNvbGF0ZShzdHJ1Y3QgcnRlX2V0aF9kZXYgKmRldiwNCj4gCWlmICghcG1kLT5yeHFb MF0uZmQpDQo+IAkJcmV0dXJuIDA7DQo+IAlpZiAoc2V0KSB7DQo+IC0JCXN0cnVjdCBydGVfZmxv dyAqZmxvdzsNCj4gKwkJc3RydWN0IHJ0ZV9mbG93ICpyZW1vdGVfZmxvdzsNCj4gDQo+IC0JCXdo aWxlICgxKSB7DQo+IC0JCQlmbG93ID0gTElTVF9GSVJTVCgmcG1kLT5pbXBsaWNpdF9mbG93cyk7 DQo+IC0JCQlpZiAoIWZsb3cpDQo+ICsJCXdoaWxlICghTElTVF9FTVBUWSgmcG1kLT5pbXBsaWNp dF9mbG93cykpIHsNCj4gKwkJCXJlbW90ZV9mbG93ID0gTElTVF9GSVJTVCgmcG1kLT5pbXBsaWNp dF9mbG93cyk7DQo+ICsJCQlpZiAoIXJlbW90ZV9mbG93KQ0KPiAJCQkJYnJlYWs7DQo+IAkJCS8q DQo+IAkJCSAqIFJlbW92ZSBhbGwgaW1wbGljaXQgcnVsZXMgb24gdGhlIHJlbW90ZS4NCj4gCQkJ ICogS2VlcCB0aGUgbG9jYWwgcnVsZSB0byByZWRpcmVjdCBwYWNrZXRzIG9uIFRYLg0KPiAJCQkg KiBLZWVwIGFsc28gdGhlIGxhc3QgaW1wbGljaXQgbG9jYWwgcnVsZTogSVNPTEFURS4NCj4gCQkJ ICovDQo+IC0JCQlpZiAoZmxvdy0+bXNnLnQudGNtX2lmaW5kZXggPT0gcG1kLT5pZl9pbmRleCkN Cj4gLQkJCQlicmVhazsNCj4gLQkJCWlmICh0YXBfZmxvd19kZXN0cm95X3BtZChwbWQsIGZsb3cs IE5VTEwpIDwgMCkNCj4gLQkJCQlnb3RvIGVycm9yOw0KPiArCQkJaWYgKHJlbW90ZV9mbG93LT5t c2cudC50Y21faWZpbmRleCAhPSBwbWQtPmlmX2luZGV4KSB7DQo+ICsJCQkJLyoNCj4gKwkJCQkg KiByZW1vdmUgVEMgZnJvbSBrZXJuZWwgYW5kDQo+ICsJCQkJICogcmVtb3RlX2Zsb3cgZnJvbSBs aXN0DQo+ICsJCQkJICovDQo+ICsJCQkJaWYgKHRhcF9mbG93X2Rlc3Ryb3lfcG1kKHBtZCwgcmVt b3RlX2Zsb3csDQo+ICsJCQkJCQlOVUxMKSA8IDApDQo+ICsJCQkJCWdvdG8gZXJyb3I7DQo+ICsJ CQl9IGVsc2Ugew0KPiArCQkJCS8qIHJlbW92ZSByZW1vdGVfZmxvdyBmcm9tIGxpc3QgKi8NCj4g KwkJCQlMSVNUX1JFTU9WRShyZW1vdGVfZmxvdywgbmV4dCk7DQo+ICsJCQkJcnRlX2ZyZWUocmVt b3RlX2Zsb3cpOw0KPiArCQkJfQ0KPiAJCX0NCj4gCQkvKiBTd2l0Y2ggdGhlIFRDIHJ1bGUgYWNj b3JkaW5nIHRvIHBtZC0+Zmxvd19pc29sYXRlICovDQo+IAkJaWYgKHRhcF9mbG93X2ltcGxpY2l0 X2NyZWF0ZShwbWQsIFRBUF9JU09MQVRFKSA9PSAtMSkNCj4gQEAgLTE3MzksOCArMTc0OCw4IEBA IGludCB0YXBfZmxvd19pbXBsaWNpdF9jcmVhdGUoc3RydWN0IHBtZF9pbnRlcm5hbHMgKnBtZCwN Cj4gCX0NCj4gCWVyciA9IHRhcF9ubF9yZWN2X2FjayhwbWQtPm5sc2tfZmQpOw0KPiAJaWYgKGVy ciA8IDApIHsNCj4gLQkJLyogU2lsZW50bHkgaWdub3JlIHJlLWVudGVyaW5nIHJlbW90ZSBwcm9t aXNjdW91cyBydWxlICovDQo+IC0JCWlmIChlcnJubyA9PSBFRVhJU1QgJiYgaWR4ID09IFRBUF9S RU1PVEVfUFJPTUlTQykNCj4gKwkJLyogU2lsZW50bHkgaWdub3JlIHJlLWVudGVyaW5nIGV4aXN0 aW5nIHJ1bGUgKi8NCj4gKwkJaWYgKGVycm5vID09IEVFWElTVCkNCj4gCQkJZ290byBzdWNjZXNz Ow0KPiAJCVRBUF9MT0coRVJSLA0KPiAJCQkiS2VybmVsIHJlZnVzZWQgVEMgZmlsdGVyIHJ1bGUg Y3JlYXRpb24gKCVkKTogJXMiLA0KPiAtLSANCj4gMi43LjQNCj4gDQoNClJlZ2FyZHMsDQpLZWl0 aA0KDQo=