From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id EA64B1B6E3 for ; Wed, 11 Apr 2018 21:56:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3564220E02; Wed, 11 Apr 2018 15:56:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Apr 2018 15:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=iYMEyMWPnT/eXkKUMJW57LA/jJ 8GS905/DwxdXUOJFw=; b=ekK9ZXNAXgfIAO7pYhp8LIQl7zzabyBqw1XRmSpLNK +P5ge8zKSNJx+AHnvpk7bj3Oz2UoJrivuCHbipGag2q5ES20pgZX90V4VofQodfB uD3sfK9sfgVk+FowpOf4No6dRhudub6E7k++bUYnzfKJ+IEYiPD224U+fHCwxrYb I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=iYMEyM WPnT/eXkKUMJW57LA/jJ8GS905/DwxdXUOJFw=; b=iyRZRHYMEedoOUHlt92yto SWRXhCP1hZ7dcbV1KymRgITYG+hkIo4cz4uXtFYZs777Eyzp91vASUceOYv0pLa8 v9tQHNHNAM6nSuBr2g7EA34xZ42HiGDU9OCxk56/BSOCjiGqDeZybt4ZV8H+PrBz 9i671vISD+JovU6V745z4AzFD5xbWNLOO9cvb3uo/4oEKV99ONhK1JA8uoXAEBAX eBXwVff9emv3Wmyye+avgh/4FnHrcsN1+2Gbr/HrJE2LJuTP0THJxVJHxnmOMN7y B1Dj6xFVw6B1WUjESrLxY+cgntXFHsS+MfsCW0URyNuMUYlehiaU/6avymbFHD3w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 66E3AE4441; Wed, 11 Apr 2018 15:56:02 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh , Andrew Rybchenko , Anatoly Burakov Cc: dev@dpdk.org Date: Wed, 11 Apr 2018 21:56:00 +0200 Message-ID: <2544114.h6jezT9v71@xps> In-Reply-To: <20180411194627.GA17965@ltp-pvn> References: <6832477.SIRo2TBDok@xps> <20180411194627.GA17965@ltp-pvn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] Build failure on RHEL 7.4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 19:56:04 -0000 11/04/2018 21:46, Pavan Nikhilesh: > On Wed, Apr 11, 2018 at 09:40:30PM +0200, Thomas Monjalon wrote: > > 11/04/2018 21:09, Andrew Rybchenko: > > > Hello, > > > > > > build fails on RHEL 7.4. I've not tried to dig it. > > > > Thanks for reporting. > > > > [...] > > > =E2=80=98FALLOC_FL_PUNCH_HOLE=E2=80=99 undeclared (first use in this = function) > > [...] > > > =E2=80=98FALLOC_FL_KEEP_SIZE=E2=80=99 undeclared (first use in this f= unction) > > > > These constants were defined in Linux 2.6.23 and 2.6.38. > > > > [...] > > > $ uname -r > > > 3.10.0-693.el7.x86_64 > > > > It should be OK. > > > > I think we are just missing > > #include >=20 > Currently there is a bug filed in glibc here for the exact same kernel ve= rsion. > https://bugzilla.redhat.com/show_bug.cgi?id=3D1476120 The man page says: "The FALLOC_FL_* flags are defined in glibc headers only since version 2.18." I guess we can workaround with a direct include.