From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f176.google.com (mail-we0-f176.google.com
 [74.125.82.176]) by dpdk.org (Postfix) with ESMTP id EBC73A6A
 for <dev@dpdk.org>; Mon, 23 Mar 2015 12:16:11 +0100 (CET)
Received: by wetk59 with SMTP id k59so134881295wet.3
 for <dev@dpdk.org>; Mon, 23 Mar 2015 04:16:11 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=W7PdAkHgUGBk6xdyGeznk0Ytf80gcDNyfTFE9AqT3yY=;
 b=kOPNPxVMsnbkY+wutK0nu4x74J1CMrQAU1hQcgJ7Z6Lwj6oG1UloDLAMY2SeMWSFbA
 wLs31bSCZmWNe7N4jBRlILTQ70xIurhmmcNSAhkDBr3WGkUAVzySb8S6MTT/cXdlvSvq
 IdovwW0rhfY3qGGlIDmlAJFC3GV7igni22SoHQvM6UZ00c8h2zx+9btYTka7XQgvOjf3
 fHN6BWxUPoTg0R57hEFLBtde2+w8QmE4bU9aHMRLdQNZ8xDHp1MPZPUgQdOQn8h12Gux
 sYySGmBHok6JLetT5N13SCyiSJK3dIBgvErBbnEL3mQBM3X0R5SUEEM90pWYHS7ugjgK
 /b6w==
X-Gm-Message-State: ALoCoQl+SU89U0pkQxmBOEZXIKF9oc+YQcvhKUEIsYe5qj9vsL7XwvxfRQNu3WNIXWmnKqEQh6Uk
X-Received: by 10.180.171.35 with SMTP id ar3mr18892900wic.24.1427109371812;
 Mon, 23 Mar 2015 04:16:11 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id g5sm905948wjr.19.2015.03.23.04.16.10
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Mar 2015 04:16:10 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pavel Boldin <pboldin@mirantis.com>
Date: Mon, 23 Mar 2015 12:15:30 +0100
Message-ID: <2544479.OZtlEpgWBm@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <1426684571-14782-1-git-send-email-pboldin@mirantis.com>
References: <1426524059-30886-1-git-send-email-pboldin+dpdk@mirantis.com>
 <1426684571-14782-1-git-send-email-pboldin@mirantis.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Fix `eventfd_link' module leakages and
	races
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2015 11:16:12 -0000

Hi Pavel,

You forgot the Signed-off-by line.

Huawei, Changchun, any comment on this patch?

2015-03-18 15:16, Pavel Boldin:
> The `eventfd_link' module provides an API to "steal" fd from another
> process had been written with a bug that leaks `struct file' because
> of the extra reference counter increment and missing `fput' call.
> 
> The other bug is using another process' `task_struct' without incrementing
> a reference counter.

As there are 2 bugs, you should provide 2 patches.

> Fix these bugs and refactor the module.

Why refactoring along with the bug fixes?
You'd have more chances to have your fixes integrated in 2.0 without
refactoring.

Thanks