From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 15D5868CA for ; Tue, 4 Oct 2016 11:34:51 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id p138so200679648wmb.1 for ; Tue, 04 Oct 2016 02:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=vTLuQShai7nrMh+ykTZJWCN0zHreJpXGBGqdH6PnBCE=; b=HDsyOYHeYVCQRfBNoKEaitle12lD0cEgKq4Bg1edtj+mYZ8XJsFJDOYKYVl6rpjWFG /Iu5WJgpv72KZdCyhKg4xmiYsGCMHLeLLe3zUr3LZQQw4qvPIGCP0BidruZqSXO/5wrr 5KYBtZip8vvL5M73/NV+mrIl4qWzneW918JnbWMrmHrUADpLGCCKmgidOCPSk6I/xwf6 L1NG5tnkfXQ+iGEhLQ2qanBSERR5SmZJ6aZaNOs2UZ+P1+H3I8SvVY9P10LoHKrSFi/P kDOW4Z4fqijFRF5sh+2X2OwSdHRQLsKBxLFT74xjifvKDDRWH3N4eraUEWB+x64IgP+/ Txxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=vTLuQShai7nrMh+ykTZJWCN0zHreJpXGBGqdH6PnBCE=; b=ZJzpMoDRs6MJWV3hzvClOd4LUf8UpYSJ2eALkoVsQ/ThFE93T8EB+adfq+3EwnN5H0 65w6CBMuCnqwL3QZrgzkGSuHWY0M91sHUTgTmmoFL5v5JfM6hGwP3fyrfxjrmyeJCx+d edyBkBmUAPUIXuuIsYvKXh/129liI1cwH/3ToxDpuIxOfKcqIUDw/XGfhzpH4LoeKlCH fAQXn0GvlejDIYrX4r98r0FFx+QAjupVJrmztzpf8SkKINkiOKyNys21K7jVoTQSbiKw pwDDxKTv/f6OltOe5vMeGXRY81dqkd+cje3NHZrhWaUqvFsG6iR6FMLEcA7Jw0+op0y1 6AVg== X-Gm-Message-State: AA6/9RnyjEiC7U+t23GQZ97UKoTFMbKwKqkBfk2MQq+2JNQffe2ZYZZa4hJXAv64ElF7BthU X-Received: by 10.194.240.71 with SMTP id vy7mr2112773wjc.90.1475573690529; Tue, 04 Oct 2016 02:34:50 -0700 (PDT) Received: from xps13.localnet (172.17.90.92.rev.sfr.net. [92.90.17.172]) by smtp.gmail.com with ESMTPSA id o2sm2568764wjo.3.2016.10.04.02.34.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Oct 2016 02:34:49 -0700 (PDT) From: Thomas Monjalon To: Wei Dai , john.mcnamara@intel.com Cc: dev@dpdk.org Date: Tue, 04 Oct 2016 11:34:33 +0200 Message-ID: <2544827.v0ahXV4zxG@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1472206104-22035-1-git-send-email-wei.dai@intel.com> References: <1472206104-22035-1-git-send-email-wei.dai@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix statistics description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 09:34:51 -0000 2016-08-26 18:08, Wei Dai: > /** > * A structure used to retrieve statistics for an Ethernet port. > + * Not all statistics fields in struct rte_eth_stats are supported > + * by any type of network interface card (NIC). If any statistics > + * field is not supported, its value is 0 . > */ > struct rte_eth_stats { I'm missing the point of this patch. Why do you think it is a fix? John, any opinion?