From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87CD3A0548; Wed, 1 Jun 2022 13:55:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D72C40689; Wed, 1 Jun 2022 13:55:30 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 1A8CC4003F; Wed, 1 Jun 2022 13:55:28 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BEA625C027E; Wed, 1 Jun 2022 07:55:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 01 Jun 2022 07:55:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1654084525; x= 1654170925; bh=ANhtlkRT5nX5TC4GTSgUTOtHhkv2Fi9wZgHDiW0jXoA=; b=X ciKi7qR/MyImJ5HqVv0e3SoB8DMiWzLX6TSLfEvOeK6437NwPpprqiRRk7rdysJW LM9BJm1joJEDzNsIXwvep2anOYUzkBOZjWfkEqqfsRkNswf2doOpfveMTUPe0Tta XXjjgTY2ir190GPS/vsSIkD88Hninkl1CE/Qu42mZ+T5RiZTJ8PHz2G56kWZ37+L Y1uhT247Sbl1VoVNGX/pbKyygvOMZD5Lj/e+WjJ8pKpGkueyITvYT4YTAYlQIblB bVRhSsVfj0uFhu5AB54ArwpCDMUc8/wSz2OUNqOq3wNwrUpaZiA+vQNh03mVV+9o lOmxmYAEaDJlnH4uZZ34g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1654084525; x= 1654170925; bh=ANhtlkRT5nX5TC4GTSgUTOtHhkv2Fi9wZgHDiW0jXoA=; b=R TJ7HNcFzMzibqb3lyUrCweXE3m47PmPGH2G1bYbtEoc/h9SFb5NxKgbJ1kNB7O++ YFB4yYkmFJ2jdlAe79g5wMf45Hi+8i+1J5hq/Z1lQXBS0kanXKFYclyrre8ZIbVv tWD2GvmZV3sElOnyJ/dopBOvCoBDdX0aOIcj8i/8VJpgsWkt0YHI8Wkr4gi8Z65D WA2DDHaPXYnehHK0tcYBfcc5t0123gedsOJ7/JLaZSWY4bzQG44UjRM3ylUYprZx TG66psGA8ziWFqcMnQwWv3UE7+q4sTRgbmcwRRjKTXUmT0tvbpUFjh3RjbAYIUyZ 24+dYKvOXGD3CnV4QPp0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrledtgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Jun 2022 07:55:24 -0400 (EDT) From: Thomas Monjalon To: Cristian Dumitrescu Cc: dev@dpdk.org, stable@dpdk.org, Venkata Suresh Kumar P , Yogesh Jangra Subject: Re: [PATCH] pipeline: fix emit instruction for invalid headers Date: Wed, 01 Jun 2022 13:55:21 +0200 Message-ID: <2546085.7s5MMGUR32@thomas> In-Reply-To: <20220427215652.49229-1-cristian.dumitrescu@intel.com> References: <20220427215652.49229-1-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/04/2022 23:56, Cristian Dumitrescu: > Fix the emit instruction for the pathological case of all headers to > be emitted being invalid. In this case, the for loop was essentially > skipped and the last emitted header (or an invalid memory location) > getting corrupted by setting its size to 0 through the assignment to > ho->n_bytes right after the for loop. > > Fixes: d60dbdc88a3e ("pipeline: create inline functions for emit instruction") > Cc: stable@dpdk.org > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Venkata Suresh Kumar P > Signed-off-by: Yogesh Jangra Applied, thanks.