From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 783448DB1 for <dev@dpdk.org>; Wed, 2 Dec 2015 11:45:47 +0100 (CET) Received: by wmec201 with SMTP id c201so246721524wme.0 for <dev@dpdk.org>; Wed, 02 Dec 2015 02:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=vct9d9MmV9LJHwgurAhmpVuUztYfUqv2dJDYjOmaxmg=; b=dpX0wLh4CLSrFFEsYmVuN1/bfK7axlAAEOhlUd8BZFPiOgtDWxdk/SV0Ml2FktTnMV 0ePeXSjNEbU1VKdDLROOqGWVoOPDLAP1wp2V6smxgeVPudCxfI+ipiIZtDmihZ/77n1J lRWQveRW0/B5SAO13rwp2AMmhiSYC2+meiGBPc8XDS067SNrIg/5+Q2DeVG6xD8H1Kfx +FjIW1C9fgscqCP80JPSHwcyv9V9bCXMzOWrqNT8gH13sj83fwR4jimlNJIK31AOkyLL hWUbSuy9FADherNKPbrsHkbKyOYVHVPaPJHTKo2/psqBCww37wwoNpPlJ7aGAyXdfG72 tyBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=vct9d9MmV9LJHwgurAhmpVuUztYfUqv2dJDYjOmaxmg=; b=jyMTi0BgrVND8ZOo5tk2pIMc/LERPSdExUwgNZnggoeXAuc6SeT0q5yEzWZX8kTWVl q2jftsFGNgzIiD3V1B1Pg180dD8V94tKf4vuOZpFE46ZVlR4WagHAAraszME3AKrfXND sBmd6xSfKH8Zd+acwWw6b44wLhgwlSqqW/c5e+fqVYcgUqBIYJUDAwXvkLzlfC+dOEOb 9mMfVUDLkjjHbOnXerh9hTve7yZ1dYjc883o6if2y7YjDxjJ1qrY3JTNZaZRMBHJKNkj BUHTUwlTrYT3RNISUQrHTAr13L45jDyhdz/wx/cyaNUARv7zjciJyEWvfyEvW2U2ZsFb lcqQ== X-Gm-Message-State: ALoCoQmoPyF7voF033MSviUQz1v/HnlwsPChxJ8mZfAB8ddkHrbWqc1TiQDZnN8HaMk+rXFT/XYO X-Received: by 10.194.204.202 with SMTP id la10mr4024713wjc.81.1449053147355; Wed, 02 Dec 2015 02:45:47 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id pn6sm2190501wjb.15.2015.12.02.02.45.46 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Dec 2015 02:45:46 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Charles (Chas) Williams" <3chas3@gmail.com> Date: Wed, 02 Dec 2015 11:44:38 +0100 Message-ID: <2551799.Q5hrDerVeS@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449051535.2645.49.camel@gmail.com> References: <1446571576-28399-1-git-send-email-3chas3@gmail.com> <1462827.BQfOhHUEb5@xps13> <1449051535.2645.49.camel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] bnx2x: tx_start_bd->vlan_or_ethertype is le16 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 02 Dec 2015 10:45:47 -0000 2015-12-02 05:18, Charles Williams: > On Wed, 2015-12-02 at 02:04 +0100, Thomas Monjalon wrote: > > 2015-12-01 18:58, Charles Williams: > > > On Wed, 2015-12-02 at 00:34 +0100, Thomas Monjalon wrote: > > > > 2015-12-01 14:37, Stephen Hemminger: > > > > > Harish Patil <harish.patil@qlogic.com> wrote: > > > > > > >2015-11-03 12:26, Chas Williams: > > > > > > >> --- a/drivers/net/bnx2x/bnx2x.c > > > > > > >> +++ b/drivers/net/bnx2x/bnx2x.c > > > > > > >> - tx_start_bd->vlan_or_ethertype = eh->ether_type; > > > > > > >> + tx_start_bd->vlan_or_ethertype > > > > > > >> + = rte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type)); > > > > > > > > > > > > Minor question - any specific reason to use rte_be_to_cpu_16() on > > > > > > ether_type alone before converting from native order to le16? > > > > > > > > > > ether_type is in network byte order (big endian) > > > > > and hardware wants little endian. On x86 the second step is a nop. > > > > > > > > Doesn't it deserve a macro rte_ntole16()? > > > > It may be in lib/librte_eal/common/include/generic/rte_byteorder.h. > > > > > > I looked I didn't see anything. This value, according to the linux > > > driver, wants to be little endian regardless of the host endian. > > > > Yes, that's why I suggest to create some macros to do this kind of conversion. > > Example: rte_ntole16 means "network to little endian 16-bit". > > Do you think it would be clearer to use? > > This is the only example of this kind of conversion in the source code > so it would be a macro for one user. If you create rte_ntole16() you > might feel obligated to create the various permutations for which there > are no consumers. Yes, that's why I was not sure of the interest.