From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com [67.231.148.157]) by dpdk.org (Postfix) with ESMTP id 729BE568A for ; Thu, 3 Dec 2015 03:54:57 +0100 (CET) Received: from pps.filterd (m0045602.ppops.net [127.0.0.1]) by mx0a-0016ce01.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tB32stbA028931; Wed, 2 Dec 2015 18:54:55 -0800 Received: from avcashub1.qlogic.com (avcashub3.qlogic.com [198.70.193.117]) by mx0a-0016ce01.pphosted.com with ESMTP id 1yj7758nm4-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 02 Dec 2015 18:54:55 -0800 Received: from AVMB3.qlogic.org ([fe80::4cd9:35c8:c701:e42d]) by avcashub3.qlogic.org ([::1]) with mapi id 14.03.0235.001; Wed, 2 Dec 2015 18:54:54 -0800 From: Rasesh Mody To: Thomas Monjalon Thread-Topic: [PATCH v3 10/11] config: Enable BNX2X driver build by default Thread-Index: AQHRJowQ2KQLVM3/XUOpX8Ml8z35FZ6rwPcAgAy7aYCAAJD/gP//jwsA Date: Thu, 3 Dec 2015 02:54:54 +0000 Message-ID: <2552F74A0BCCBE4DBE2AD218C81B28110864B718@avmb3.qlogic.org> References: <1448351076-23161-1-git-send-email-rasesh.mody@qlogic.com> <1740319.2UiCSnWV9s@xps13> <2552F74A0BCCBE4DBE2AD218C81B28110864B591@avmb3.qlogic.org> <2436122.zBamVnyWNt@xps13> In-Reply-To: <2436122.zBamVnyWNt@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=8003 signatures=670664 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1512030054 Cc: "dev@dpdk.org" , Sony Chacko Subject: Re: [dpdk-dev] [PATCH v3 10/11] config: Enable BNX2X driver build by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 02:54:57 -0000 > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, December 02, 2015 5:30 PM > > 2015-12-03 00:54, Rasesh Mody: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Tuesday, November 24, 2015 6:26 AM > > > > > > We still have a compilation error when zlib.h is missing. > > > Please keep it disabled until we have a solution (probably a "configu= re" > > > script). > > > > Just to clarify - are you planning to have a generic ./configure script= that > would address external dependencies like zlib or are you proposing that w= e > provide the configure script specific to bnx2x PMD? > > There will be a configure script in the next release. > It will handle every dependencies. Ok, thanks! > > > Another option could be to not to include "bnx2x" if zlib.h header is n= ot > found by having a check in drivers/net/Makefile? > > How do you find zlib.h? > It seems to be a job for gcc in a configure script. I was thinking of something like this... diff --git a/dpdk-2.1.0/drivers/net/Makefile b/dpdk-2.1.0/drivers/net/Makef= ile index 5ebf963..25f3767 100644 --- a/dpdk-2.1.0/drivers/net/Makefile +++ b/dpdk-2.1.0/drivers/net/Makefile @@ -32,7 +32,13 @@ include $(RTE_SDK)/mk/rte.vars.mk DIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) +=3D af_packet -DIRS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D bnx2x +ZLIB_VERNUM :=3D $(shell if [ -f /usr/include/zlib.h ]; then grep ZLIB_VER= NUM /usr/include/zlib.h | cut -d" " -f3; fi) +ifneq ($(ZLIB_VERNUM),) + ZLIB_VERNUM_GE_1252 :=3D $(shell (($(ZLIB_VERNUM) >=3D 0x1252)) || echo = $?) + ifneq ($(ZLIB_VERNUM_GE_1252)), 1) + DIRS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D bnx2x + endif +endif DIRS-$(CONFIG_RTE_LIBRTE_PMD_BOND) +=3D bonding DIRS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) +=3D cxgbe DIRS-$(CONFIG_RTE_LIBRTE_E1000_PMD) +=3D e1000 Also a similar check in mk/rte.app.mk. Is this something we can live with till we have the configure script? ________________________________ This message and any attached documents contain information from the sendin= g company or its parent company(s), subsidiaries, divisions or branch offic= es that may be confidential. If you are not the intended recipient, you may= not read, copy, distribute, or use this information. If you have received = this transmission in error, please notify the sender immediately by reply e= -mail and then delete this message.