From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com [67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 9637F2C40 for ; Tue, 22 Mar 2016 02:14:15 +0100 (CET) Received: from pps.filterd (m0085408.ppops.net [127.0.0.1]) by mx0b-0016ce01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u2M1CSPX018500; Mon, 21 Mar 2016 18:14:13 -0700 Received: from avcashub1.qlogic.com ([198.186.0.116]) by mx0b-0016ce01.pphosted.com with ESMTP id 21sq4f2uuu-1 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NOT); Mon, 21 Mar 2016 18:14:13 -0700 Received: from AVMB3.qlogic.org ([fe80::689d:1159:4632:e0eb]) by avcashub2.qlogic.org ([::1]) with mapi id 14.03.0235.001; Mon, 21 Mar 2016 18:14:12 -0700 From: Rasesh Mody To: Stephen Hemminger CC: "thomas.monjalon@6wind.com" , "bruce.richardson@intel.com" , "dev@dpdk.org" , Ameen Rahman , Harish Patil , Sony Chacko Thread-Topic: [dpdk-dev] [PATCH v3 05/10] qede: Add core driver Thread-Index: AQHRgXnMl++gGUrRuEqa6pB0Dr3rop9kob8A///BZEA= Date: Tue, 22 Mar 2016 01:14:11 +0000 Message-ID: <2552F74A0BCCBE4DBE2AD218C81B2811086C9D51@avmb3.qlogic.org> References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com> <1458348805-32648-6-git-send-email-rasesh.mody@qlogic.com> <20160321103244.4e158f5d@xeon-e3> In-Reply-To: <20160321103244.4e158f5d@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5800 definitions=8111 signatures=670703 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1603220017 Subject: Re: [dpdk-dev] [PATCH v3 05/10] qede: Add core driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 01:14:16 -0000 > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, March 21, 2016 10:33 AM >=20 > On Fri, 18 Mar 2016 17:53:20 -0700 > Rasesh Mody wrote: >=20 > > +static struct eth_dev_ops qede_eth_dev_ops =3D { > > + .dev_configure =3D qede_dev_configure, > > + .dev_infos_get =3D qede_dev_info_get, > > + .rx_queue_setup =3D qede_rx_queue_setup, > > + .rx_queue_release =3D qede_rx_queue_release, > > + .tx_queue_setup =3D qede_tx_queue_setup, > > + .tx_queue_release =3D qede_tx_queue_release, > > + .dev_start =3D qede_dev_start, > > + .dev_set_link_up =3D qede_dev_set_link_up, > > + .dev_set_link_down =3D qede_dev_set_link_down, > > + .link_update =3D qede_link_update, > > + .promiscuous_enable =3D qede_promiscuous_enable, > > + .promiscuous_disable =3D qede_promiscuous_disable, > > + .allmulticast_enable =3D qede_allmulticast_enable, > > + .allmulticast_disable =3D qede_allmulticast_disable, > > + .dev_stop =3D qede_dev_stop, > > + .dev_close =3D qede_dev_close, > > + .stats_get =3D qede_get_stats, > > + .mac_addr_add =3D qede_mac_addr_add, > > + .mac_addr_remove =3D qede_mac_addr_remove, > > + .vlan_offload_set =3D qede_vlan_offload_set, > > + .vlan_filter_set =3D qede_vlan_filter_set, > > + .flow_ctrl_set =3D qede_flow_ctrl_set, > > + .flow_ctrl_get =3D qede_flow_ctrl_get, }; > > + >=20 > All eth_dev_ops structures should be marked const. > It makes it harder for attacker to find a handle. Sure Stephen! Will take care of that in a follow on patch. Thanks! Rasesh