From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <rasesh.mody@qlogic.com> Received: from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com [67.231.156.153]) by dpdk.org (Postfix) with ESMTP id F26E62BD6 for <dev@dpdk.org>; Thu, 24 Mar 2016 02:52:09 +0100 (CET) Received: from pps.filterd (m0085408.ppops.net [127.0.0.1]) by mx0b-0016ce01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u2O1pa0d018144; Wed, 23 Mar 2016 18:52:07 -0700 Received: from avcashub1.qlogic.com ([198.186.0.116]) by mx0b-0016ce01.pphosted.com with ESMTP id 21sq4f8rnw-1 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NOT); Wed, 23 Mar 2016 18:52:03 -0700 Received: from AVMB3.qlogic.org ([fe80::689d:1159:4632:e0eb]) by avcashub2.qlogic.org ([::1]) with mapi id 14.03.0235.001; Wed, 23 Mar 2016 18:52:01 -0700 From: Rasesh Mody <rasesh.mody@qlogic.com> To: "Richardson, Bruce" <bruce.richardson@intel.com>, "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Ameen Rahman <ameen.rahman@qlogic.com>, Harish Patil <harish.patil@qlogic.com>, Sony Chacko <sony.chacko@qlogic.com> Thread-Topic: [PATCH v3 00/10] qede: Add qede PMD Thread-Index: AQHRgXm/A68FWrrSFkOVgjmveD3TJJ9lzFWAgAIIo/A= Date: Thu, 24 Mar 2016 01:52:01 +0000 Message-ID: <2552F74A0BCCBE4DBE2AD218C81B2811086FED07@avmb3.qlogic.org> References: <1458348805-32648-1-git-send-email-rasesh.mody@qlogic.com> <59AF69C657FD0841A61C55336867B5B0359F0E37@IRSMSX103.ger.corp.intel.com> In-Reply-To: <59AF69C657FD0841A61C55336867B5B0359F0E37@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5800 definitions=8113 signatures=670704 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1603240025 Subject: Re: [dpdk-dev] [PATCH v3 00/10] qede: Add qede PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 24 Mar 2016 01:52:10 -0000 Hi Bruce, > From: Richardson, Bruce [mailto:bruce.richardson@intel.com] > Sent: Tuesday, March 22, 2016 4:21 AM >=20 > I've had a quick scan over this patchset, and as you've probably seen I'v= e > made some public comments on it. General comments on the whole > patchset are: > * Please run checkpatch on the patchset and clear up as many issues as yo= u > can. There are a number of typos called out which especially must be fixe= d. > Both myself and Thomas always run checkpatch against patches before > applying them. [I suggest using Thomas's checkpatches.sh script to do the > checks as it disables many unnecessary warnings from checkpatch] > * Please put in commit descriptions for all patches bar those doing trivi= al > things. The first three patches probably don't need a commit message, but > the rest do. * We had run checkpatch script from dpdk on v1 submission, checkpatch.pl f= rom 3.15 kernel and had addressed all the check patch issues. * However, we got a recommendation "Running checkpatch with --ignore PREF= ER_KERNEL_TYPES,LINE_SPACING,PARENTHESIS_ALIGNMENT,BIT_MACRO,NETWORKING_BLO= CK_COMMENT_STYLE,SPLIT_STRING,COMPARISON_TO_NULL,CONCATENATED_STRING". With= v2 we used these ignore options with checkpatch.pl from 4.5 kernel and add= ressed checkpatch reported errors/warnings/checks. However, the spellcheck = was missing from both the submissions. * With v3 there was no code change(meant for dpdk-next-net) We'll address spellchecks and other issues that may have been additionally = found by latest checkpatch scripts. We'll also add the commit message to ma= ke the patches descriptive and submit v4 patch set. Thanks! Rasesh=20 =20 > /Bruce >=20 > > -----Original Message----- > > From: Rasesh Mody [mailto:rasesh.mody@qlogic.com] > > Sent: Saturday, March 19, 2016 12:53 AM > > To: thomas.monjalon@6wind.com; Richardson, Bruce > > <bruce.richardson@intel.com> > > Cc: dev@dpdk.org; ameen.rahman@qlogic.com; harish.patil@qlogic.com; > > sony.chacko@qlogic.com; Rasesh Mody <rasesh.mody@qlogic.com> > > Subject: [PATCH v3 00/10] qede: Add qede PMD > > > > Submitting v3 patch series for QEDE PMD. There is no code change from > > v2 series except PMD version change. Earlier we had generated and > > tested the > > v2 series against dpdk tree then latest. > > > > The v3 series includes: > > - Patches generated and tested against latest dpdk-next-net > > - Reworked MAINTAINERS patch to make it apply cleanly > > - Incorporated Overview.rst update in the documentation patch > > > > Please Apply. > > > > Thanks! > > Rasesh > > > > Rasesh Mody (10): > > qede: Add maintainers > > qede: Add documentation > > qede: Add license file > > qede: Add base driver > > qede: Add core driver > > qede: Add L2 support > > qede: Add SRIOV support > > qede: Add attention support > > qede: Add DCBX support > > qede: Enable PMD build > > > > MAINTAINERS | 7 + > > config/common_base | 14 + > > doc/guides/nics/index.rst | 1 + > > doc/guides/nics/overview.rst | 78 +- > > doc/guides/nics/qede.rst | 340 + > > drivers/net/Makefile | 1 + > > drivers/net/qede/LICENSE.qede_pmd | 28 + > > drivers/net/qede/Makefile | 95 + > > drivers/net/qede/base/bcm_osal.c | 178 + > > drivers/net/qede/base/bcm_osal.h | 395 + > > drivers/net/qede/base/common_hsi.h | 714 ++ > > drivers/net/qede/base/ecore.h | 746 ++ > > drivers/net/qede/base/ecore_attn_values.h |13287 > > +++++++++++++++++++++++++++ > > drivers/net/qede/base/ecore_chain.h | 724 ++ > > drivers/net/qede/base/ecore_cxt.c | 1961 ++++ > > drivers/net/qede/base/ecore_cxt.h | 157 + > > drivers/net/qede/base/ecore_cxt_api.h | 79 + > > drivers/net/qede/base/ecore_dcbx.c | 887 ++ > > drivers/net/qede/base/ecore_dcbx.h | 55 + > > drivers/net/qede/base/ecore_dcbx_api.h | 160 + > > drivers/net/qede/base/ecore_dev.c | 3578 ++++++++ > > drivers/net/qede/base/ecore_dev_api.h | 497 + > > drivers/net/qede/base/ecore_gtt_reg_addr.h | 42 + > > drivers/net/qede/base/ecore_gtt_values.h | 33 + > > drivers/net/qede/base/ecore_hsi_common.h | 1912 ++++ > > drivers/net/qede/base/ecore_hsi_eth.h | 1912 ++++ > > drivers/net/qede/base/ecore_hsi_tools.h | 1081 +++ > > drivers/net/qede/base/ecore_hw.c | 992 ++ > > drivers/net/qede/base/ecore_hw.h | 269 + > > drivers/net/qede/base/ecore_hw_defs.h | 49 + > > drivers/net/qede/base/ecore_init_fw_funcs.c | 1275 +++ > > drivers/net/qede/base/ecore_init_fw_funcs.h | 263 + > > drivers/net/qede/base/ecore_init_ops.c | 599 ++ > > drivers/net/qede/base/ecore_init_ops.h | 103 + > > drivers/net/qede/base/ecore_int.c | 2225 +++++ > > drivers/net/qede/base/ecore_int.h | 234 + > > drivers/net/qede/base/ecore_int_api.h | 277 + > > drivers/net/qede/base/ecore_iov_api.h | 933 ++ > > drivers/net/qede/base/ecore_iro.h | 115 + > > drivers/net/qede/base/ecore_iro_values.h | 59 + > > drivers/net/qede/base/ecore_l2.c | 1798 ++++ > > drivers/net/qede/base/ecore_l2.h | 151 + > > drivers/net/qede/base/ecore_l2_api.h | 401 + > > drivers/net/qede/base/ecore_mcp.c | 1928 ++++ > > drivers/net/qede/base/ecore_mcp.h | 304 + > > drivers/net/qede/base/ecore_mcp_api.h | 611 ++ > > drivers/net/qede/base/ecore_proto_if.h | 28 + > > drivers/net/qede/base/ecore_rt_defs.h | 446 + > > drivers/net/qede/base/ecore_sp_api.h | 42 + > > drivers/net/qede/base/ecore_sp_commands.c | 525 ++ > > drivers/net/qede/base/ecore_sp_commands.h | 137 + > > drivers/net/qede/base/ecore_spq.c | 944 ++ > > drivers/net/qede/base/ecore_spq.h | 284 + > > drivers/net/qede/base/ecore_sriov.c | 3422 +++++++ > > drivers/net/qede/base/ecore_sriov.h | 390 + > > drivers/net/qede/base/ecore_status.h | 30 + > > drivers/net/qede/base/ecore_utils.h | 31 + > > drivers/net/qede/base/ecore_vf.c | 1322 +++ > > drivers/net/qede/base/ecore_vf.h | 415 + > > drivers/net/qede/base/ecore_vf_api.h | 186 + > > drivers/net/qede/base/ecore_vfpf_if.h | 590 ++ > > drivers/net/qede/base/eth_common.h | 526 ++ > > drivers/net/qede/base/mcp_public.h | 1195 +++ > > drivers/net/qede/base/nvm_cfg.h | 919 ++ > > drivers/net/qede/base/reg_addr.h | 1107 +++ > > drivers/net/qede/qede_eth_if.c | 456 + > > drivers/net/qede/qede_eth_if.h | 176 + > > drivers/net/qede/qede_ethdev.c | 986 ++ > > drivers/net/qede/qede_ethdev.h | 157 + > > drivers/net/qede/qede_if.h | 164 + > > drivers/net/qede/qede_logs.h | 93 + > > drivers/net/qede/qede_main.c | 601 ++ > > drivers/net/qede/qede_rxtx.c | 1364 +++ > > drivers/net/qede/qede_rxtx.h | 187 + > > drivers/net/qede/rte_pmd_qede_version.map | 4 + > > mk/rte.app.mk | 2 + > > scripts/test-build.sh | 1 + > > 77 files changed, 58239 insertions(+), 39 deletions(-) create mode > > 100644 doc/guides/nics/qede.rst create mode 100644 > > drivers/net/qede/LICENSE.qede_pmd create mode 100644 > > drivers/net/qede/Makefile create mode 100644 > > drivers/net/qede/base/bcm_osal.c create mode 100644 > > drivers/net/qede/base/bcm_osal.h create mode 100644 > > drivers/net/qede/base/common_hsi.h > > create mode 100644 drivers/net/qede/base/ecore.h create mode 100644 > > drivers/net/qede/base/ecore_attn_values.h > > create mode 100644 drivers/net/qede/base/ecore_chain.h > > create mode 100644 drivers/net/qede/base/ecore_cxt.c create mode > > 100644 drivers/net/qede/base/ecore_cxt.h create mode 100644 > > drivers/net/qede/base/ecore_cxt_api.h > > create mode 100644 drivers/net/qede/base/ecore_dcbx.c > > create mode 100644 drivers/net/qede/base/ecore_dcbx.h > > create mode 100644 drivers/net/qede/base/ecore_dcbx_api.h > > create mode 100644 drivers/net/qede/base/ecore_dev.c create mode > > 100644 drivers/net/qede/base/ecore_dev_api.h > > create mode 100644 drivers/net/qede/base/ecore_gtt_reg_addr.h > > create mode 100644 drivers/net/qede/base/ecore_gtt_values.h > > create mode 100644 drivers/net/qede/base/ecore_hsi_common.h > > create mode 100644 drivers/net/qede/base/ecore_hsi_eth.h > > create mode 100644 drivers/net/qede/base/ecore_hsi_tools.h > > create mode 100644 drivers/net/qede/base/ecore_hw.c create mode > > 100644 drivers/net/qede/base/ecore_hw.h create mode 100644 > > drivers/net/qede/base/ecore_hw_defs.h > > create mode 100644 drivers/net/qede/base/ecore_init_fw_funcs.c > > create mode 100644 drivers/net/qede/base/ecore_init_fw_funcs.h > > create mode 100644 drivers/net/qede/base/ecore_init_ops.c > > create mode 100644 drivers/net/qede/base/ecore_init_ops.h > > create mode 100644 drivers/net/qede/base/ecore_int.c create mode > > 100644 drivers/net/qede/base/ecore_int.h create mode 100644 > > drivers/net/qede/base/ecore_int_api.h > > create mode 100644 drivers/net/qede/base/ecore_iov_api.h > > create mode 100644 drivers/net/qede/base/ecore_iro.h create mode > > 100644 drivers/net/qede/base/ecore_iro_values.h > > create mode 100644 drivers/net/qede/base/ecore_l2.c create mode > > 100644 drivers/net/qede/base/ecore_l2.h create mode 100644 > > drivers/net/qede/base/ecore_l2_api.h > > create mode 100644 drivers/net/qede/base/ecore_mcp.c create mode > > 100644 drivers/net/qede/base/ecore_mcp.h create mode 100644 > > drivers/net/qede/base/ecore_mcp_api.h > > create mode 100644 drivers/net/qede/base/ecore_proto_if.h > > create mode 100644 drivers/net/qede/base/ecore_rt_defs.h > > create mode 100644 drivers/net/qede/base/ecore_sp_api.h > > create mode 100644 drivers/net/qede/base/ecore_sp_commands.c > > create mode 100644 drivers/net/qede/base/ecore_sp_commands.h > > create mode 100644 drivers/net/qede/base/ecore_spq.c create mode > > 100644 drivers/net/qede/base/ecore_spq.h create mode 100644 > > drivers/net/qede/base/ecore_sriov.c > > create mode 100644 drivers/net/qede/base/ecore_sriov.h > > create mode 100644 drivers/net/qede/base/ecore_status.h > > create mode 100644 drivers/net/qede/base/ecore_utils.h > > create mode 100644 drivers/net/qede/base/ecore_vf.c create mode > > 100644 drivers/net/qede/base/ecore_vf.h create mode 100644 > > drivers/net/qede/base/ecore_vf_api.h > > create mode 100644 drivers/net/qede/base/ecore_vfpf_if.h > > create mode 100644 drivers/net/qede/base/eth_common.h > > create mode 100644 drivers/net/qede/base/mcp_public.h > > create mode 100644 drivers/net/qede/base/nvm_cfg.h create mode > > 100644 drivers/net/qede/base/reg_addr.h create mode 100644 > > drivers/net/qede/qede_eth_if.c create mode 100644 > > drivers/net/qede/qede_eth_if.h create mode 100644 > > drivers/net/qede/qede_ethdev.c create mode 100644 > > drivers/net/qede/qede_ethdev.h create mode 100644 > > drivers/net/qede/qede_if.h create mode 100644 > > drivers/net/qede/qede_logs.h create mode 100644 > > drivers/net/qede/qede_main.c create mode 100644 > > drivers/net/qede/qede_rxtx.c create mode 100644 > > drivers/net/qede/qede_rxtx.h create mode 100644 > > drivers/net/qede/rte_pmd_qede_version.map > > > > -- > > 1.7.10.3