From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com [67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 1AB399606 for ; Fri, 1 Apr 2016 02:23:18 +0200 (CEST) Received: from pps.filterd (m0085408.ppops.net [127.0.0.1]) by mx0b-0016ce01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u310MWxO025374; Thu, 31 Mar 2016 17:23:16 -0700 Received: from avcashub1.qlogic.com ([198.186.0.115]) by mx0b-0016ce01.pphosted.com with ESMTP id 2203pbw7qd-1 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NOT); Thu, 31 Mar 2016 17:23:15 -0700 Received: from AVMB3.qlogic.org ([fe80::689d:1159:4632:e0eb]) by avcashub1.qlogic.org ([::1]) with mapi id 14.03.0235.001; Thu, 31 Mar 2016 17:23:14 -0700 From: Rasesh Mody To: "thomas.monjalon@6wind.com" CC: "dev@dpdk.org" , Bruce Richardson Thread-Topic: [dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes Thread-Index: AQHRezgTRWXQDxLQjkC2cRrUMpnG2J9mDYcAgA5TrZA= Date: Fri, 1 Apr 2016 00:23:14 +0000 Message-ID: <2552F74A0BCCBE4DBE2AD218C81B2811087070F4@avmb3.qlogic.org> References: <1457660877-2570-1-git-send-email-rasesh.mody@qlogic.com> <1457660877-2570-2-git-send-email-rasesh.mody@qlogic.com> <20160322142958.GA21000@bricha3-MOBL3> In-Reply-To: <20160322142958.GA21000@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5800 definitions=8121 signatures=670706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603180000 definitions=main-1604010003 Subject: Re: [dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 00:23:18 -0000 Hi Thaomas, > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Tuesday, March 22, 2016 7:30 AM >=20 > On Thu, Mar 10, 2016 at 05:47:56PM -0800, Rasesh Mody wrote: > > Signed-off-by: Harish Patil > > Signed-off-by: Rasesh Mody > > --- > > drivers/net/bnx2x/bnx2x.c | 207 +++++++++++++++++-------------= ----- > --- > > drivers/net/bnx2x/bnx2x.h | 4 +- > > drivers/net/bnx2x/bnx2x_ethdev.c | 53 ++++++++++ > > drivers/net/bnx2x/bnx2x_rxtx.c | 47 +++++---- > > 4 files changed, 173 insertions(+), 138 deletions(-) > > > This patch needs a commit message with a description of changes and how > they help with performance. >=20 > If there are multiple changes being made to improve the performance, or > add in extra TX features, they would be better split into separate patche= s, > with one unique change per patch. If any of the changes are bug-fixes as > opposed to performance improvements (since the word "fixes" appears in > the title here), they should each be in a separate patch, with a message > describing the fix and including a "fixes" line in the message as describ= ed > here: > http://dpdk.org/doc/guides/contributing/patches.html#commit-messages- > body >=20 > Thanks, > /Bruce The feedback is addressed and v2 patches have been submitted. Pls. apply to= rel_16_04. Thanks! Rasesh