From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rasesh.mody@qlogic.com>
Received: from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com
 [67.231.156.153]) by dpdk.org (Postfix) with ESMTP id 511CD2BF8
 for <dev@dpdk.org>; Thu,  7 Apr 2016 07:10:42 +0200 (CEST)
Received: from pps.filterd (m0085408.ppops.net [127.0.0.1])
 by mx0b-0016ce01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id
 u3757iuO017829; Wed, 6 Apr 2016 22:10:40 -0700
Received: from avcashub1.qlogic.com ([198.186.0.117])
 by mx0b-0016ce01.pphosted.com with ESMTP id 222xg469qe-1
 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NOT);
 Wed, 06 Apr 2016 22:10:40 -0700
Received: from AVMB3.qlogic.org ([fe80::689d:1159:4632:e0eb]) by
 avcashub3.qlogic.org ([::1]) with mapi id 14.03.0235.001; Wed, 6 Apr 2016
 22:10:38 -0700
From: Rasesh Mody <rasesh.mody@qlogic.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
 "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Ameen Rahman <ameen.rahman@qlogic.com>,
 Harish Patil <harish.patil@qlogic.com>
Thread-Topic: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get
Thread-Index: AQHRj5yCL0nkhvdnOkWy4+e2QyUgqZ99eIgAgAB/kMA=
Date: Thu, 7 Apr 2016 05:10:38 +0000
Message-ID: <2552F74A0BCCBE4DBE2AD218C81B281108754525@avmb3.qlogic.org>
References: <1459903028-3329-1-git-send-email-rasesh.mody@qlogic.com>
 <1459903028-3329-3-git-send-email-rasesh.mody@qlogic.com>
 <E923DB57A917B54B9182A2E928D00FA6128A446D@IRSMSX102.ger.corp.intel.com>
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA6128A446D@IRSMSX102.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.1.4.10]
disclaimer: bypass
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=nai engine=5800 definitions=8127
 signatures=670708
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0
 priorityscore=1501 suspectscore=0
 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011
 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.0.1-1603180000 definitions=main-1604070077
Subject: Re: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Apr 2016 05:10:42 -0000

> From: Van Haaren, Harry [mailto:harry.van.haaren@intel.com]
> Sent: Wednesday, April 06, 2016 7:33 AM
>=20
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rasesh Mody
> > Subject: [dpdk-dev] [PATCH v3 3/4] bnx2x: Enhance stats get
>=20
> Hi Rasesh,
>=20
> > +	snprintf(xstats[num].name, sizeof(xstats[num].name),
> "brb_drops");
>=20
> I don't understand what a "brb" drop is.
>=20
>=20
> > +	snprintf(xstats[num].name, sizeof(xstats[num].name), "tx_pfc");
>=20
> Similarly here, and with some other of the xstats strings, it doesn't bec=
ome
> clear to me what exactly the value represents.
>=20
> "mac_filter_discard" is descriptive and readable, but the next stat has
> "mf_tag_discard" - these small inconsistencies make it much harder
> (impossible?) to scrap the xstats strings and retrieve useful metadata.
>=20
> I'll suggest leaving the xstats implementation part of this patch until t=
he next
> release, and we can align on the names of the stats.

We'll re-work the patch to accommodate your suggestions.=20

>=20
> -Harry