From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 36A062934 for ; Mon, 21 Nov 2016 09:59:12 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id g23so133904007wme.1 for ; Mon, 21 Nov 2016 00:59:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=wZacFedLD2hzA1QzVOZkOra2PgNMKFbOnPUs4GTxecU=; b=Zh6guPMAtCX2vsAnOWur8nc5hgV3zE3rzpyNR8PBjUwq3Qxrm5L/giJJ1bQrij1CmX sOJksfiDbrAQ8GscsZoTsNqIJ7AwpbCe0f0XGHaDjVr0qkfyrIgBrmPqc0bDhXBT2N2N Kb7yq89A3kAEoNUl+QkMRg940WYKtTKbMjh9ARWb5vVxofr1pKNZ2PC/vKwW59tEMc6E sG5/4eckBE5nfDiiFCnKpYlfSpi3m0v43WyhOu2mRAYsOSrZeZU8xf12D9/OEKkr8QIt /4lf9YedjHYkA5zZaqs6oaZ6jyDj48RNd6m5anMsaK/GQQmizee2XsWBC9V1Uqs0lvZ/ wiPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=wZacFedLD2hzA1QzVOZkOra2PgNMKFbOnPUs4GTxecU=; b=DvcN7s6cYe+1/AtUh7JFJl3FXftEgO7iCWR1eF+6wuAeYeXMjJFFfVB4bRjrT7Q/0l TzRdqwmcu1qn9cXZmYB1eNYXKvy+DOxuXPB4dyyzD4er4uKG3POLXEVFHeOGBRVBQtde uDUBquJDLy1z7FXQo3s6Vr1wRzjanCKDi5Q3wO+OF5DlIubbyxkmiYmE54oeuMHlUSpi s23xe9tnXc9Z8n2dCZ+BS8fLV1SzXGMM1kobLNlTxPtENUBusaXvBDe8/fo3YLhSTOm0 +5p4fy76mZniqfJ71gYZgWswZIQCurPVwg7lNAK71EpcHr3TMYZbEeKp7XAfI+tKNfUk 2xqw== X-Gm-Message-State: AKaTC02BrFp2YetaW8K56OLmhYg0Z24DyxSvNmqZqHelxM9eoO52S/wvhXB77ugcmAIm+Str X-Received: by 10.28.125.136 with SMTP id y130mr13500826wmc.112.1479718751893; Mon, 21 Nov 2016 00:59:11 -0800 (PST) Received: from xps13.localnet (183.20.90.92.rev.sfr.net. [92.90.20.183]) by smtp.gmail.com with ESMTPSA id ua15sm23727636wjb.1.2016.11.21.00.59.10 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Nov 2016 00:59:11 -0800 (PST) Date: Mon, 21 Nov 2016 00:59:11 -0800 (PST) X-Google-Original-Date: Mon, 21 Nov 2016 09:59 +0100 From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <2553236.UbBGAtvXhx@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2e666e61-bc4e-1a37-f26a-a0fc18a4d988@solarflare.com> References: <1695254.J03lBVJQtY@xps13> <2e666e61-bc4e-1a37-f26a-a0fc18a4d988@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Solarflare PMD submission question X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 08:59:12 -0000 2016-11-21 11:46, Andrew Rybchenko: > On 11/21/2016 11:19 AM, Thomas Monjalon wrote: > >> Before submitting 56 patches I'd like to double-check that checkpatch.pl > >> errors (for example, because of assignments in the 'if' condition, > >> parenthesis around return value) is not a show-stopper for base driver > >> import. > > You can run checkpatches.sh or send the patches to checkpatch@dpdk.org. > > The script check-git-log.sh can also guide you for the expected formatting. > > Yes, I did it and it helped me to find and fix some coding standard > violations. > > The problem with libefx (base driver) is that it is existing code which > follows FreeBSD and illumos coding conventions which contradict to > checkpatches.sh sometimes (e.g. require parenthesis around return > value). Other example of error produced by checkpatches.sh is assign in > if. It is widely used in the code to assign return code value and > compare it vs 0 in one line. It is not a coding standard conflict, but > it is very wide-spread in the code (so changing it will produce too many > changes not strictly required/useful). > > So, may I repeat my question if it is a show-stopper for base driver or > acceptable. I would vote to accept these minor style warnings for the base driver. Ferruh, any comment?