From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by dpdk.org (Postfix) with ESMTP id A18DC2BA6 for ; Tue, 11 Oct 2016 15:57:31 +0200 (CEST) Received: by mail-lf0-f44.google.com with SMTP id l131so10112782lfl.2 for ; Tue, 11 Oct 2016 06:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=adoawpszYNFj3nbjktFtqq1sxHRnANbX5xKzQBRrXAI=; b=bzgeNFjJoGdjzJShyKjz6Ofk3X9b3kc+fUDV3jMyUeQ9l47cWkqXdW4G/ojK1XpBxt k0iWffkx9CZGDvNCNKQ7G7y94n9pbmZ9QSckdu3VXXwrA2prVJy/1CGg0xozMgoCaYZC jwy6mLqMRHYw4tSv60+wHhR41WStAh8q2YTocIjkAbzbQcDGaRgMQlqOkPLZiOYkMx8F ED09Y1GuhXhkqWjaK6D4ZZ+6+Bu+dfVfnk+2gc8g33LeGXArwKU36ehmpR+aMIWEwBZ3 kQgTDxmfsnq3lqF4dM5aRXlGRQaHWXmhzJZj1G9L608LZB7lQW75PjHflVqlaF/bA8uQ +Y8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=adoawpszYNFj3nbjktFtqq1sxHRnANbX5xKzQBRrXAI=; b=TpFsA+7lsdpGIea/DCnI0RmJ8afzZq2ddXfBjBTusWKPukimfZH/zFsTeMlIb49f0Y Qbfb3XsL4xqiNpRrDKlZccPjqYuN4RJfJCwbaKQX7Diu+w4LwPFk03ab5Ery8fe2NHoX O//+GBTvkkeDNlpt9WF29KmvlXTEXfaXe0jeuc4uG7ElJX5NE7Mn+mOi2bxL+YvMGH60 o0erBntjRxFbmzbE5n8xYv0K9fPnMnN4V1+ypPk6kD29wEn1bHONfG5zsl2jFn9YQg5i yXEMl2qHw2IidIrq/B/vWGp8LI7O1GXkxmunidDyN3g8WgvnLabp1PbCgSN7KOfTUQj1 9QrA== X-Gm-Message-State: AA6/9Rkgr+Az0doW4Ts8s90SVkUqcWYgiXDRNqRczazE3ZYgf3am5KOf/wBNTHq4G+bDWW0y X-Received: by 10.25.74.143 with SMTP id x137mr2760019lfa.10.1476194251244; Tue, 11 Oct 2016 06:57:31 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id m63sm1051027lfm.25.2016.10.11.06.57.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Oct 2016 06:57:30 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Cc: Shreyansh Jain , "david.marchand@6wind.com" , dev@dpdk.org Date: Tue, 11 Oct 2016 15:57:29 +0200 Message-ID: <2554688.6PDizipyct@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161011133824.GA31866@hmsreliant.think-freely.org> References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <20161011133824.GA31866@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 13:57:31 -0000 2016-10-11 09:38, Neil Horman: > This also begs the question in my mind, is it really worth changing the macro? > I really don't think it is. The registration macros are pretty descriptive as > they stand, and have already changed 3 or 4 times in the last 6 months, which > suggests to me that any change here is really just churn more than meaningful > change. You can make the argument that the name might be more in line with the > library its implemented in or what not, but in truth, its easy to understand > what the macros do (in their previous or current incantations), and any change > that just makes them the same as other macros in their naming is really more > trouble than its worth. Neil, the long term goal is to stop having some identifiers which do not start with RTE_ in our exported .h files. I think it is a reasonable policy, for a library, to live in a well defined namespace.