From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C729343270; Thu, 2 Nov 2023 18:00:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5F1040262; Thu, 2 Nov 2023 18:00:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DDF1640144 for ; Thu, 2 Nov 2023 18:00:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698944414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cXrhyLk8+KiXepZ6sCRfjWISx/NQZgYm1E1E5MVyJsE=; b=EXDsg6MRmOUy8+7TyAfnyhrQ0KiGtZqg6OH2exvO6KTxiBcQ4lzuQrgjUx6wx4TU0NmRki kQzflLA6qJqC4NJ3mwfzaSLUtXpx/sT+btFs8c9hwo4aRCsQEicD3Vk8uGQmln2RtaxRS9 DPgc5GL52JDBIOLunFuCmZMXSBMO7ew= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-NMDhWhtSOmu-CppTkMGjdw-1; Thu, 02 Nov 2023 13:00:09 -0400 X-MC-Unique: NMDhWhtSOmu-CppTkMGjdw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9AC45811E7D; Thu, 2 Nov 2023 17:00:08 +0000 (UTC) Received: from [10.39.208.33] (unknown [10.39.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1284D10102; Thu, 2 Nov 2023 17:00:06 +0000 (UTC) Message-ID: <25566cf0-2c91-43b3-b7cd-7a93b935c4b2@redhat.com> Date: Thu, 2 Nov 2023 18:00:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/11] test/bbdev: update python script parameters To: "Chautru, Nicolas" , "Vargas, Hernan" , "dev@dpdk.org" , "gakhil@marvell.com" , "Rix, Tom" , Hemant Agrawal Cc: "Zhang, Qi Z" References: <20230929181328.104311-1-hernan.vargas@intel.com> <20230929181328.104311-3-hernan.vargas@intel.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nicolas, On 10/27/23 22:02, Chautru, Nicolas wrote: > Hi Maxime, > > Back on this discussion and there was some misunderstanding. This is really a bug for the python script helper only. > The -t option is already reserved for bbdev-test application (and in doc) for setting the iter_max (see main.c). > The problem is that the python script introduced -t by mistake for an additional time out when calling the binary to be handled in the script only, now resolving this by using -T to avoid clash with existing -t option. > No one is genuinely using -t for timeout. > Ping me if still unclear I actually understood it from the beginning, -t was used as timeout option in the test-bbdev.py script, this patch changes -t to now represent the maximum number of iterations. I'm sure you can see the problem if someone was using -t for timeout in some CI (Neither me or you can guarantee this is not used)? If you think we really should change the meaning of this option, we should have a deprecation notice, have both -t and -T to represent timeout during the deprecation period and emit a warning when -t is used. Once deprecated, you can assign -t to max iterations. Sounds good? Regards, Maxime > Nic > >> -----Original Message----- >> From: Chautru, Nicolas >> Sent: Thursday, October 19, 2023 8:10 AM >> To: Maxime Coquelin ; Vargas, Hernan >> ; dev@dpdk.org; gakhil@marvell.com; Rix, Tom >> ; Hemant Agrawal >> Cc: Zhang, Qi Z >> Subject: RE: [PATCH v1 02/11] test/bbdev: update python script parameters >> >> Hi Maxime, >> In practice anyone using that API is already using the one defined in the >> patch below and not using -t for time out. So not a concern to do it properly >> through that patch. >> Heman, any concern on your side with this change? >> >>> -----Original Message----- >>> From: Maxime Coquelin >>> Sent: Thursday, October 19, 2023 11:19 AM >>> To: Chautru, Nicolas ; Vargas, Hernan >>> ; dev@dpdk.org; gakhil@marvell.com; Rix, >> Tom >>> >>> Cc: Zhang, Qi Z >>> Subject: Re: [PATCH v1 02/11] test/bbdev: update python script >>> parameters >>> >>> >>> >>> On 10/19/23 11:01, Chautru, Nicolas wrote: >>>> Hi Maxime, >>>> >>>> I believe there was some historical discrepancy, even in doc both >>>> appeared >>> but none of the 2 -t options with the cap. >>>> https://doc.dpdk.org/guides/tools/testbbdev.html >>>> Resolving this historical issue here. >>> >>> Ok, then we should fix the doc, not the code. >>> >>> Thanks, >>> Maxime >>> >>>> Thanks >>>> Nic >>>> >>>>> -----Original Message----- >>>>> From: Maxime Coquelin >>>>> Sent: Tuesday, October 17, 2023 9:08 PM >>>>> To: Vargas, Hernan ; dev@dpdk.org; >>>>> gakhil@marvell.com; Rix, Tom >>>>> Cc: Chautru, Nicolas ; Zhang, Qi Z >>>>> >>>>> Subject: Re: [PATCH v1 02/11] test/bbdev: update python script >>>>> parameters >>>>> >>>>> >>>>> >>>>> On 9/29/23 20:13, Hernan Vargas wrote: >>>>>> Update the timeout argument and default values. >>>>>> Update EAL help message and default value. >>>>>> Add iter_max and snr arguments. >>>>>> >>>>>> Signed-off-by: Hernan Vargas >>>>>> --- >>>>>> app/test-bbdev/test-bbdev.py | 22 ++++++++++++++++++---- >>>>>> app/test-bbdev/test_bbdev_perf.c | 2 +- >>>>>> 2 files changed, 19 insertions(+), 5 deletions(-) >>>>>> >>>>>> diff --git a/app/test-bbdev/test-bbdev.py >>>>>> b/app/test-bbdev/test-bbdev.py index 9cdb4659724d..8d0145076e4d >>>>>> 100755 >>>>>> --- a/app/test-bbdev/test-bbdev.py >>>>>> +++ b/app/test-bbdev/test-bbdev.py >>>>>> @@ -25,12 +25,12 @@ def kill(process): >>>>>> help="specifies path to the bbdev test app", >>>>>> default=dpdk_path + "/" + dpdk_target + >>>>>> "/app/dpdk-test- >>> bbdev") >>>>>> parser.add_argument("-e", "--eal-params", >>>>>> - help="EAL arguments which are passed to the test app", >>>>>> - default="--vdev=baseband_null0") >>>>>> -parser.add_argument("-t", "--timeout", >>>>>> + help="EAL arguments which must be passed to the test >> app", >>>>>> + default="--vdev=baseband_null0 -a00:00.0") >>>>>> +parser.add_argument("-T", "--timeout", >>>>>> type=int, >>>>>> help="Timeout in seconds", >>>>>> - default=300) >>>>>> + default=600) >>>>>> parser.add_argument("-c", "--test-cases", >>>>>> nargs="+", >>>>>> help="Defines test cases to run. Run all if >>>>>> not >>>>>> specified") @@ -48,6 +48,14 @@ def kill(process): >>>>>> type=int, >>>>>> help="Operations enqueue/dequeue burst size.", >>>>>> default=[32]) >>>>>> +parser.add_argument("-s", "--snr", >>>>>> + type=int, >>>>>> + help="SNR in dB for BLER tests", >>>>>> + default=0) >>>>>> +parser.add_argument("-t", "--iter-max", >>>>> >>>>> We shouldn't change parameters meaning, it will silently break >>>>> existing scripts making use of it. >>>>> >>>>>> + type=int, >>>>>> + help="Max iterations", >>>>>> + default=6) >>>>>> parser.add_argument("-l", "--num-lcores", >>>>>> type=int, >>>>>> help="Number of lcores to run.", @@ -68,6 >>>>>> +76,12 @@ def kill(process): >>>>>> >>>>>> params.extend(["--"]) >>>>>> >>>>>> +if args.snr: >>>>>> + params.extend(["-s", str(args.snr)]) >>>>>> + >>>>>> +if args.iter_max: >>>>>> + params.extend(["-t", str(args.iter_max)]) >>>>>> + >>>>>> if args.num_ops: >>>>>> params.extend(["-n", str(args.num_ops)]) >>>>>> >>>>>> diff --git a/app/test-bbdev/test_bbdev_perf.c >>>>>> b/app/test-bbdev/test_bbdev_perf.c >>>>>> index 276bbf0a2e6d..faea26c10eed 100644 >>>>>> --- a/app/test-bbdev/test_bbdev_perf.c >>>>>> +++ b/app/test-bbdev/test_bbdev_perf.c >>>>>> @@ -26,7 +26,7 @@ >>>>>> >>>>>> #define MAX_QUEUES RTE_MAX_LCORE >>>>>> #define TEST_REPETITIONS 100 >>>>>> -#define TIME_OUT_POLL 1e8 >>>>>> +#define TIME_OUT_POLL 1e9 >>>>>> #define WAIT_OFFLOAD_US 1000 >>>>>> >>>>>> #ifdef RTE_BASEBAND_FPGA_LTE_FEC >>>> >