From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH v1] config/arm: fix clang cross part number
Date: Mon, 08 Feb 2021 17:43:03 +0100 [thread overview]
Message-ID: <2557094.JohW55DncD@thomas> (raw)
In-Reply-To: <bde958030b084896bec055afd0eb4f7a@pantheon.tech>
08/02/2021 15:46, Juraj Linkeš:
> I accidentally submitted this as an RFC patch. Please consider this to be a regular patch.
>
> With that said, Thomas, would it be possible to get this into the release?
Yes
For the sake of understanding, is it an issue due to a missing rebase?
Or was it a miss in the testing of the patch?
> > -----Original Message-----
> > From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > Sent: Monday, February 8, 2021 3:44 PM
> > To: bruce.richardson@intel.com; thomas@monjalon.net;
> > Ruifeng.Wang@arm.com; Honnappa.Nagarahalli@arm.com;
> > jerinjacobk@gmail.com; ferruh.yigit@intel.com
> > Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> > Subject: [RFC PATCH v1] config/arm: fix clang cross part number
> >
> > Rename the 'default' part number in clang cross-file to fix the following issue:
> > config/arm/meson.build:238:2: ERROR: Problem encountered: Unsupported
> > part number default of implementer generic. Please add support for it or use the
> > generic (-Dmachine=generic) build.
> >
> > Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > ---
> > config/arm/arm64_armv8_linux_clang_ubuntu1804 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> > b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> > index 8d8cc50ea4..57095c1304 100644
> > --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> > +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> > @@ -15,6 +15,6 @@ endian = 'little'
> >
> > [properties]
> > implementer_id = 'generic'
> > -part_number = 'default'
> > +part_number = 'generic'
> > c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
> > c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-toolchain=/usr']
> > --
> > 2.20.1
>
>
next prev parent reply other threads:[~2021-02-08 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:44 Juraj Linkeš
2021-02-08 14:46 ` Juraj Linkeš
2021-02-08 16:43 ` Thomas Monjalon [this message]
2021-02-08 16:46 ` Juraj Linkeš
2021-02-08 17:26 ` Thomas Monjalon
2021-02-08 18:01 ` Juraj Linkeš
2021-02-10 10:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2557094.JohW55DncD@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=juraj.linkes@pantheon.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).