From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39B36A0093; Thu, 21 May 2020 10:26:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 47CC61D65B; Thu, 21 May 2020 10:26:24 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id D0E761D65A for ; Thu, 21 May 2020 10:26:22 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 34D1C580FA4; Thu, 21 May 2020 04:26:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 21 May 2020 04:26:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= paSrzJl1MhJylcIRbNJOJPRIs332/IlJHnr6iUgHDts=; b=s66uj384igfpVvgo tJG1JyF8IHKwqeu6cJK7GTNZDz9BObR5vf38ifwMwlOdAUmelVFkYhuH1o/vhu1m avRjjnaG8/dH+s8nIUQCkhiZgOk9DLfLt/pezZ1/90OJsnDVCertwINHPV0Fwr89 93NOmYiInx2nf86VYzrUmOzDrlWIROGIH47EQX9aH0clL030qkRdqVLA+9Cby77d V+tcehBxvQjAxiI98TLJ72QYTtQHnVDqShmA/ESv62oWVDsmtwWFyL7nrHJh/bY7 98G6OC3jsKj2wtBN923wPAZ4bjKBWyWxw/BfalZ9A2+4C0p4JzfpHXqNg3SR118e YKLneg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=paSrzJl1MhJylcIRbNJOJPRIs332/IlJHnr6iUgHD ts=; b=igEcmWs8ULK03ECZG8SrC+ubf6q2nKVGzXHN3gwnkJkhe+hLAwO64Ammy FeHgp+m+IGRxvi03afCGBsuJVBnmrpuJO3r0AzAH1OIoUqkj7DAVSkymRhJScP3R Hy3ZlY9BmU+2s9AMQeb/LaZ4iIyZMEDT4kJ6Wf6279lX1e0X4DXPkJqHabhmRLIY gOmkErV7X7VmLE38nvvsTJMc7XfaBWKRwOEcEHzd+XLZ+VT0QwC7EtZhL119IYhI 5+Vxz5Odi4HZiXBwLfAsgYWBY5q44ZWtk/1gZFfHsa+FP5+mqEAFXvMfm2acuyRD KBJqz6pcgSAMpRDnu+xfEIVrlmvyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudduuddgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D6D33066479; Thu, 21 May 2020 04:26:18 -0400 (EDT) From: Thomas Monjalon To: Fady Bader Cc: "dev@dpdk.org" , Honnappa Nagarahalli , "talshn@mellanox.com" , "yohadt@mellanox.com" , "olivier.matz@6wind.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "anand.rawat@intel.com" , "ranjit.menon@intel.com" , "dmitry.kozliuk@gmail.com" , Honnappa Nagarahalli , nd Date: Thu, 21 May 2020 10:26:17 +0200 Message-ID: <2557491.TtRDRv7A1Z@thomas> In-Reply-To: References: <20200520104445.9072-1-fady@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ring: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/05/2020 06:17, Honnappa Nagarahalli: > > > > Subject: [dpdk-dev] [PATCH v2] ring: build on Window > ^^^^ change this to 'eal'. > > Even though the compilation error points to rte_ring, this is not a issue in rte_ring library. Suggest changing the commit message to something like "eal: add per_lcore__rte_errno to export list for Windows". The dedicated title prefix is "eal/windows:" > > Exported per_lcore__rte_errno function to compile ring for windows. > > > > compilation error logs: > > librte_ring_rte_ring.c.obj : error LNK2019: unresolved external symbol > > per_lcore__rte_errno referenced in function rte_ring_lookup > > > > The cause was that per_lcore__rte_errno function wasn't included in the > > export list. > > To solve this per_lcore__rte_errno was added to the Windows export list. > > > > Signed-off-by: Fady Bader > > Depends-on: series-9374 ("Windows basic memory management") > > --- The "Depends-on" line is not supposed to be part of the merged commit. The trick is to insert "---" line on top of such annotation, so it will be automatically skipped when applying the patch with "git am". We use the same trick for changelogs. Reminder: a v2 patch should include a changelog and be sent with these options: -v2 --annotate --in-reply-to 'MESSAGE-ID-OF-v1'