From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
Dekel Peled <dekelp@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check
Date: Thu, 28 Mar 2019 18:28:23 +0000 [thread overview]
Message-ID: <256192b8-a885-0813-76bc-b38abf102b15@intel.com> (raw)
In-Reply-To: <DB7PR05MB4410A39D2BDBC1DAC6860A48D7590@DB7PR05MB4410.eurprd05.prod.outlook.com>
On 3/28/2019 10:29 AM, Ali Alnubani wrote:
> Hi Ferruh,
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Wednesday, March 27, 2019 11:31 AM
>> To: Shahaf Shuler <shahafs@mellanox.com>; Dekel Peled
>> <dekelp@mellanox.com>; Ali Alnubani <alialnu@mellanox.com>;
>> dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check
>>
>> On 3/25/2019 12:02 PM, Ferruh Yigit wrote:
>>> On 3/24/2019 9:26 AM, Shahaf Shuler wrote:
>>>> Thursday, March 21, 2019 11:34 AM, Dekel Peled:
>>>>> Subject: RE: [PATCH] net/mlx5: add missing return value check
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Ali Alnubani
>>>>>> Sent: Thursday, March 21, 2019 11:07 AM
>>>>>> To: dev@dpdk.org
>>>>>> Cc: Shahaf Shuler <shahafs@mellanox.com>; Dekel Peled
>>>>>> <dekelp@mellanox.com>
>>>>>> Subject: [PATCH] net/mlx5: add missing return value check
>>>>>>
>>>>>> Fixes: d86406b965df ("net/mlx5: support new representor naming
>>>>>> format")
>>>>>> Cc: dekelp@mellanox.com
>>>>>>
>>>>>> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
>>>>
>>>> Applied to next-net-mlx, thanks.
>>>>
>>>
>>> Squashed into relevant commit [1] in next-net, thanks.
>>>
>>> [1]
>>> net/mlx5: support new representor naming format
>>>
>>
>> 'main' repo get the original patch without squash, so can't squash now,
>> merged as a incremental patch ...
>>
>> Applied to dpdk-next-net/master, thanks.
>
> A more detailed commit body:
>
> This patch fixes the build failure with message:
> drivers/net/mlx5/mlx5_ethdev.c: In function ‘mlx5_sysfs_switch_info’:
> drivers/net/mlx5/mlx5_ethdev.c:1381:3: error: ignoring return value
> of ‘fscanf’, declared with attribute warn_unused_result [-Werror=unused-result]
> fscanf(file, "%s", port_name);
> ^
> Which reproduces on Ubuntu 16.04 LTS with
> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609.
>
> Fixes: b2f3a3810125 ("net/mlx5: support new representor naming format")
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Acked-by: Dekel Peled <dekelp@mellanox.com>
Commit log updated in next-net as suggested, thanks.
next prev parent reply other threads:[~2019-03-28 18:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 9:07 Ali Alnubani
2019-03-21 9:07 ` Ali Alnubani
2019-03-21 9:26 ` Slava Ovsiienko
2019-03-21 9:26 ` Slava Ovsiienko
2019-03-21 9:34 ` Dekel Peled
2019-03-21 9:34 ` Dekel Peled
2019-03-24 9:26 ` Shahaf Shuler
2019-03-24 9:26 ` Shahaf Shuler
2019-03-25 12:02 ` Ferruh Yigit
2019-03-25 12:02 ` Ferruh Yigit
2019-03-27 9:31 ` Ferruh Yigit
2019-03-27 9:31 ` Ferruh Yigit
2019-03-28 10:29 ` Ali Alnubani
2019-03-28 10:29 ` Ali Alnubani
2019-03-28 18:28 ` Ferruh Yigit [this message]
2019-03-28 18:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=256192b8-a885-0813-76bc-b38abf102b15@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alialnu@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).