DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Avi Kivity <avi@scylladb.com>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] vfio: support iommu group zero
Date: Wed, 09 Dec 2015 22:12:33 +0100	[thread overview]
Message-ID: <2562631.e9AmeysRzG@xps13> (raw)
In-Reply-To: <1449683756-13381-1-git-send-email-stephen@networkplumber.org>

2015-12-09 09:55, Stephen Hemminger:
> The current implementation of VFIO will not with the new no-IOMMU mode
> in 4.4 kernel. The original code assumed that IOMMU group zero would
> never be used. Group numbers are assigned starting at zero, and up
> until now the group numbers came from the hardware which is likely
> to use group 0 for system devices that are not used with DPDK.
> 
> The fix is to allow 0 as a valid group and rearrange code
> to split the return value from the group value.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> Why was this ignored? It was originally sent on 26 Oct 15 back
> when IOMMU discussion was lively.

There was no review of this patch.
The patch has been marked as deferred recently when it was too late
to do such feature changes in DPDK code:
	http://dpdk.org/dev/patchwork/patch/8035/

So I guess you have tested the VFIO no-iommu patch.
Is it working well with DPDK with only this patch for group zero?
Have you talked to Alex Williamson?
He was requesting some feedbacks:
	http://dpdk.org/ml/archives/dev/2015-December/029291.html

Thanks

  reply	other threads:[~2015-12-09 21:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 17:55 Stephen Hemminger
2015-12-09 21:12 ` Thomas Monjalon [this message]
2015-12-09 21:51   ` Stephen Hemminger
2015-12-09 21:58   ` Stephen Hemminger
2015-12-09 22:49     ` Thomas Monjalon
2015-12-09 23:12       ` Stephen Hemminger
2015-12-09 23:22         ` Alex Williamson
2015-12-10  0:52           ` Stephen Hemminger
2015-12-10  1:52             ` Alex Williamson
2015-12-10  9:57 ` Burakov, Anatoly
2015-12-10 20:30   ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2015-10-27  2:34 Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2562631.e9AmeysRzG@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=alex.williamson@redhat.com \
    --cc=avi@scylladb.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).