From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id E5DF5AB08 for ; Fri, 13 Jan 2017 16:53:47 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r126so70890109wmr.0 for ; Fri, 13 Jan 2017 07:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=7FAGkAXfN+4IiTM7NnN9mqRXROks0YCsuCbeMlSiFqM=; b=0AbIqys92GLHFYS/uBWczDcvLiSEeo+P+IlseDLb1p6+V3v7r+jcwRarDKZVyB43c4 4vnAgAKPM8EiE5nUmOGBuON0VBkus/Wc7O4KpiB/UJy+Q4gnYbKKRahg5H3GNUQFm9bB iRET3ISwGFBcGaRgJaonUCP+J6Em5XYNU3EQ7baC0HeL5UtI7T93dj52HpvjlpmVuAgr bNodQYJUGBNgj5HwsRlp3TRMenWF6t3eGFd+haFC8mD9tXqhOHcaWAD7Ab512X81YCMO w2KO4iF/VMe1rtHSmSOhvCnTBsOFBblLQkLESVVRgF0EGT50uI0T2F9Z4PUGT38cJ/nL hQRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=7FAGkAXfN+4IiTM7NnN9mqRXROks0YCsuCbeMlSiFqM=; b=osmRsKz5epXY4wrRr7y+TGcGN2wwPhp1Mmsj1TKlgQ9T1lBSoiU+QB81TO1CQOqi6B bBw72XHHnur8kLjClx2Erv5QNDGZCY6KjtltJ9pjHcoB7CrXflXpUvLRHXVtAqZNqjS2 GkAICPDVfkc9oDdZQhdiAzSsVU4oN2YxHH4oXci97EGiG1XtOv9NgiGyErItsJHkMu81 ZCsqNcQSlWTaj0RsnXBTAO+vxa6p9aQC8AF17NKx+6lGJtx0XUVLk6YV1UkYkJAhGyI0 xxwtP0Ayc9N1dTwF/FAiiptvowDj27XVb8dEgczULKTpuNmEFwgv7IJniQoQzYf8r5XC XcdQ== X-Gm-Message-State: AIkVDXJ5zFYQroH5yDaCxjIz/ON/tlA9hHfmmUE9nhjKTdXQVneLdtwn41Si7q7Oj78iaYXY X-Received: by 10.28.4.216 with SMTP id 207mr2710856wme.45.1484322827647; Fri, 13 Jan 2017 07:53:47 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id m78sm5107235wmd.8.2017.01.13.07.53.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jan 2017 07:53:47 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Fri, 13 Jan 2017 16:53:46 +0100 Message-ID: <2563842.f8ghPspXGG@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170113032155.GA31838@localhost.localdomain> References: <1484207214-13638-1-git-send-email-jerin.jacob@caviumnetworks.com> <6167bd74-c515-fc12-744d-9168a633c646@intel.com> <20170113032155.GA31838@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 15:53:48 -0000 2017-01-13 08:51, Jerin Jacob: > On Thu, Jan 12, 2017 at 03:27:30PM +0000, Ferruh Yigit wrote: > > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > > >> 2017-01-12 13:16, Jerin Jacob: > > >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > >>> +endif > > >> > > >> _LDLIBS is an internal variable of rte.app.mk. > > >> Please could you check that there is no issue when using LDLIBS instead > > >> of _LDLIBS? > > > > LDLIBS is not helping the situation as LDLIBS comes before the _LDLIBS-y > mk/rte.app.mk:LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS) > > But moving to EXTRA_LDLIBS looks OK.But it has to be under CONFIG_RTE_LIBRTE_IXGBE_PMD > > Thomas, Ferruh > Let me know if you have any objection on below mentioned diff > > -ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > +EXTRA_LDLIBS += -lrte_pmd_ixgbe > endif You need to keep the shared lib check. Anyway, EXTRA_LDLIBS should be reserved to users and not used in a Makefile. I prefer your initial patch using _LDLIBS. Any objection to merge initial proposal?