From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BAFC27CB0; Mon, 14 Jan 2019 17:27:30 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2EE2A29929; Mon, 14 Jan 2019 11:27:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 11:27:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=38dzmU94iz8AYQQLnGxhrJoo/vypqG1drZEmUb4aHAU=; b=B3e+PZDVuF5q 2KBknr8zth/jiBvaARUILIOFy3qQwZwNAa2Bx+zDU96B29fo9deMM9c86RDqsrHD KSMGh8qgRWY1/c70/NXfSLLCUH0qpRBN8KCE0Ziast2ii7Us/CbaM2Ptcy8bwMY8 ERaamb3nPWmsgGzLykPRqQuhkz4tnPQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=38dzmU94iz8AYQQLnGxhrJoo/vypqG1drZEmUb4aH AU=; b=nbn/XgcUhQJEtQCZcEO6LJWxIb8YU4FB5h/PrHtSrjsZTi/Vph/9qSvUU Ui8qsbc6BCO2Qvh6lSl32btS3zyy7B+Mzn9v5tDxSSjQOLAJarn2P2X7cZ2qEIXy 43P+Sf7gkTu7E00OFS0pXa+8RQCFm7zq6uIw04agPNlPPYeCUXxZWBVXq3J9W/Dp KWe4MkstdrAQqHKVwJ5f0/rJk/VTfComlGyd8f3dtFnWewY1vbiBKo/n2PpcDYf2 U4TOgNnClaFecnqT9lG9hHGmRoZWfa5baqQ6g7Q32RK+HXG7ef15/epvWoAk2D3Z vJubr5s5BtXLjltC+ShvKPeGVpPcQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedugdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B36E3E4662; Mon, 14 Jan 2019 11:27:28 -0500 (EST) From: Thomas Monjalon To: Ilya Maximets Cc: dev@dpdk.org, Pavan Nikhilesh , stable@dpdk.org Date: Mon, 14 Jan 2019 17:27:27 +0100 Message-ID: <2566607.iMXo4xvV1S@xps> In-Reply-To: <20190114161442.8277-1-i.maximets@samsung.com> References: <20190114161442.8277-1-i.maximets@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 16:27:31 -0000 14/01/2019 17:14, Ilya Maximets: > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > But 'rte_atomic.h' is a generic header that included to the > external apps like OVS while building with DPDK. As a result, > clang build of OVS fails on ARMv8 if DPDK built using gcc: > > include/generic/rte_atomic.h:215:9: error: > implicit declaration of function '__atomic_exchange_2' > is invalid in C99 > include/generic/rte_atomic.h:494:9: error: > implicit declaration of function '__atomic_exchange_4' > is invalid in C99 > include/generic/rte_atomic.h:772:9: error: > implicit declaration of function '__atomic_exchange_8' > is invalid in C99 > > We need to check for current compiler, not the compiler used for > DPDK build. Right, API cannot rely on internal build system configuration. > Fixes: 7bdccb93078e ("eal: fix ARM build with clang") > Cc: stable@dpdk.org > > Signed-off-by: Ilya Maximets Acked-by: Thomas Monjalon