From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michael Qiu <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] Fix compile issue in i686 platform
Date: Thu, 26 Nov 2015 22:14:14 +0100 [thread overview]
Message-ID: <2567901.2WFrbjZVWM@xps13> (raw)
In-Reply-To: <1448501706-21718-2-git-send-email-michael.qiu@intel.com>
2015-11-26 09:35, Michael Qiu:
> In i686 platform, long is 32bit, so XXX_CYCLECOUNTER_MASK
> need define as 'ULL'
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
This patch is correct but the description is not exact:
I have no issue with my i686 compiler.
For future reference, please could you be more precise
about the reproduction environment? Is it related to a specific compiler?
We also need to add these lines:
Fixes: 9c857bf6be87 ("igb: support ieee1588 functions for device time")
Fixes: 1c4445e1f28e ("ixgbe: support ieee1588 functions for device time")
Fixes: f3a4e40eca0c ("i40e: support ieee1588 functions for device time")
next prev parent reply other threads:[~2015-11-26 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 1:35 [dpdk-dev] [PATCH 1/2] examples/distributor: Fix compile issue Michael Qiu
2015-11-26 1:35 ` [dpdk-dev] [PATCH 2/2] Fix compile issue in i686 platform Michael Qiu
2015-11-26 21:14 ` Thomas Monjalon [this message]
2015-11-27 2:02 ` Qiu, Michael
2015-11-26 14:29 ` [dpdk-dev] [PATCH 1/2] examples/distributor: Fix compile issue Thomas Monjalon
2015-11-26 21:01 ` Thomas Monjalon
2015-11-27 1:16 ` Wan, Qun
2015-11-27 3:36 ` [dpdk-dev] [PATCH 1/2 v2] " Michael Qiu
2015-11-27 3:36 ` [dpdk-dev] [PATCH 2/2 v2] Fix compile issue in i686 platform Michael Qiu
2015-11-27 9:10 ` Thomas Monjalon
2015-11-27 12:21 ` [dpdk-dev] [PATCH 1/2 v2] examples/distributor: Fix compile issue De Lara Guarch, Pablo
2015-11-27 20:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2567901.2WFrbjZVWM@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).