From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 334949223 for ; Thu, 26 Nov 2015 22:15:33 +0100 (CET) Received: by wmvv187 with SMTP id v187so46443107wmv.1 for ; Thu, 26 Nov 2015 13:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=mvQqB0UAMNYNgkLqgop0GgwTq6GMPx5OepQcoCW7sts=; b=1Yzrq0lW5jaO6lpsQl48hMouVCykFsbh8fqG6onxTgQg8iKGE9IKvH9BXWhyMKsMYe VzkhSDhvMENiXiHv87eoNSLWNjuPGko6pOk4/5iEHQM6d8CHNf/vn53bOrPnqtQ2rbfY ZIjZLTGDuRblGDp6ytOeuEhm7GzKGHqYyoQ6iivvkwEeQ1U9OPLuZE3egX/PqTPL5OJr z+NBTm0HS8wLBsXYzP0SZr+aKue1nG9FLW+oT/6S8DnwmzvNeUSdpMOeuiON6cKyEdb4 WI5T6ueosdZUEcakoL0GoU1nb3A3WTrAYYA7O1HMekSRbX3HLjCjlHebHstv5Wgsiw/Z hdSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=mvQqB0UAMNYNgkLqgop0GgwTq6GMPx5OepQcoCW7sts=; b=L0dm69RMXB0V2zvegSB6sPAnb9OIcqGehXZ6q+izYtU0ndva+M4ttHwkt0uFQ/mwmW Hoo1tiYfL31pA3vXLCL4E1hAcC6hSu7UtG0jaZWu8nDjH8OLyfd4LIRgMiWA/RGnjGEk pUgXEMPVvr5Rkfsd+oBlM9TyXTyapsWB9q+wxeLSU6tSbhdWthRmjDllMgViiUuChI7J sN0YfYyrKL5l4sjlWDRi3QdN8vsPO2zKz/6Xt8d1bJgxRXyFvXaKGU6mWNzjSTXtLGOO 7Xn7s9W/ZWWnEu99w0itePDH17WQ8+YTeFpp285griOTd6FoGqUgphRDgDt5yRUz9IXT /rhQ== X-Gm-Message-State: ALoCoQn9P4qoDCpMdhCEmTdVYqssIqTVQ0VI4aMbaNM+e/AKposJi11wKhZSTBM4mpH1wrTghnJ6 X-Received: by 10.28.24.199 with SMTP id 190mr6344233wmy.101.1448572533043; Thu, 26 Nov 2015 13:15:33 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id u17sm4460757wmd.8.2015.11.26.13.15.32 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 26 Nov 2015 13:15:32 -0800 (PST) From: Thomas Monjalon To: Michael Qiu Date: Thu, 26 Nov 2015 22:14:14 +0100 Message-ID: <2567901.2WFrbjZVWM@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1448501706-21718-2-git-send-email-michael.qiu@intel.com> References: <1448501706-21718-1-git-send-email-michael.qiu@intel.com> <1448501706-21718-2-git-send-email-michael.qiu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] Fix compile issue in i686 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2015 21:15:33 -0000 2015-11-26 09:35, Michael Qiu: > In i686 platform, long is 32bit, so XXX_CYCLECOUNTER_MASK > need define as 'ULL' > > Signed-off-by: Michael Qiu This patch is correct but the description is not exact: I have no issue with my i686 compiler. For future reference, please could you be more precise about the reproduction environment? Is it related to a specific compiler? We also need to add these lines: Fixes: 9c857bf6be87 ("igb: support ieee1588 functions for device time") Fixes: 1c4445e1f28e ("ixgbe: support ieee1588 functions for device time") Fixes: f3a4e40eca0c ("i40e: support ieee1588 functions for device time")