From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DBBBA034C; Thu, 24 Feb 2022 23:51:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE7F04113D; Thu, 24 Feb 2022 23:51:48 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id CC8DD40141 for ; Thu, 24 Feb 2022 23:51:46 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 60A5C5C0121; Thu, 24 Feb 2022 17:51:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 24 Feb 2022 17:51:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=MB9vf3ltpr88sz yRP6WS/6wEGAes2gRxztdoFG489ss=; b=kt1O0lpYDbym/NquJGwZETJB6vXS+6 OVjPLoaC1xC3xPX5NL4RPQ+NrySMHsOrr4mTkaPB0+iIkXB4yhk8/FEGoKGSXvVO eedkXWO7qmkcD+PAyjHg9cT33SsdUJypHBBQkE7KsnmqxKp61DfbtMeyvmbIR+vH WWx/c7veqhtfERnOeX91pyI+o9obZaDZeOYOR+ToS7vPUTgadxxg/5FeceUp/Mic qK0HPR8xW85lNJpdjzR8o6LgvSVG8qsRXlQsJDmv8EBnvVNsCebXhlB/AC9wRgDg c3YKmZptTp2rYlxUN0j89meBwZrJls+DUFnmuSLvYwyCX91o3NfpPRSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=MB9vf3ltpr88szyRP6WS/6wEGAes2gRxztdoFG489 ss=; b=X5NQ4aUykQUA6YNSk+iQrVRlxLKi8+T10ePJiSqhuBhcpa0IjrJcRvfWn VDgcxNU7vOrBKJgDAStyI6h4ISSlfwmFMgOY2O609iOCDECIbJubgJH+s9l0UoEk gSaSsYjos8eLpbsU6z+P305kIdjQOmjTR53VLOEmQDdiPCRo3K3Guuv2ipxoqBsK sIVMmMYooSMvKSWkf7KSu3+BqmoK15d3a7zU81C31uvUkb2KhzWPkqPbMXthXKB3 ceXxW6WY5P0un8KtDCCacFVwBfkv6a9JNKTx42kiUB/wIpUfKrkP2Ohie0+IedVO EYjNG1E+yU+Vbhz+XstupecYQNVeA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledvgdduieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu veegvdeggedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Feb 2022 17:51:45 -0500 (EST) From: Thomas Monjalon To: Megha Ajmera , Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, stephen@networkplumber.org, john.mcnamara@intel.com, sham.singh.thakur@intel.com Subject: Re: [PATCH v2] sched: fix integer handling issue Date: Thu, 24 Feb 2022 23:51:44 +0100 Message-ID: <2569533.BddDVKsqQX@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86EE7@smartserver.smartshare.dk> References: <20220222131851.2944637-1-megha.ajmera@intel.com> <20220223173630.2951400-1-megha.ajmera@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D86EE7@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/02/2022 19:13, Morten Br=F8rup: > > From: Megha Ajmera [mailto:megha.ajmera@intel.com] > > Sent: Wednesday, 23 February 2022 18.37 > >=20 > > Masking of core mask was incorrect. Instead of using 1U for shifting, > > it > > should be using 1LU as the result is assigned to uint64. > >=20 > > CID 375859: Potentially overflowing expression "1U << app_main_core" > > with > > type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit > > arithmetic, and then used in a context that expects an expression of > > type "uint64_t" (64 bits, unsigned). > >=20 > > Coverity issue: 375859 > >=20 > > Signed-off-by: Megha Ajmera > > --- > > - if (app_used_core_mask & (1u << app_main_core)) { > > + if (app_used_core_mask & (RTE_BIT64(app_main_core))) { >=20 > No need for parenthesis around RTE_BIT64(app_main_core). =46ixed while merging. > Acked-by: Morten Br=F8rup Applied, thanks.