From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 0BC9D68F2 for ; Tue, 17 May 2016 07:31:15 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id e201so124434137wme.0 for ; Mon, 16 May 2016 22:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=3vZxR7dzJ6CqTEpsljh7k+Dt0RkJDKH/bzccmJrE5is=; b=uhhYkGe0qXeygqPPhTvr7QSbX5DrW6/ulTjpe79njoTn3vU+vowOumzNQxDVAWPeZd atb/IA7yjvtPLnDgn4eaU7GtJNieg7xpJf4E0TOm7sRH91lDCWE+Z+SAQXl02CPif5be U3YYKxRn9U1aOyNg5MOOZGfadSk/vjK5B305ml8Ad7Zo3mox3qE1x9vdBesiSAZ+LC+U /nwIOPOE4aqUhqTZf5VFSi1hvOWljotDlPffiEd1d7GwPpQJppQrFpvswZuz4x650HRP yUDvJAwNSs0/3K7+AdtX/1dir6b0rviBBqq+Q77suO6S8SUnam7QA5ZQEyzdWspSjyEY /gpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=3vZxR7dzJ6CqTEpsljh7k+Dt0RkJDKH/bzccmJrE5is=; b=YT48tNpzDCzGfv5VfrEPujHC62MDUqT3Rphxq/2tlYx+zpZzO1YDMWVcwWpdfd4T4t UjVg9CWYKAiPs+WppC4WlV3dC1FT8rLdVnA2i8bG+HKDazzjkPIehC9Gf2p8Rbs7JGLB 73a5BDweHE+XlCABZHk0X4UoqEH9NYPuvqxr5lR1RAGo4JD5v85dkqb2ijtH4J6J3SB6 km/4QK3wc5qWocAhw8QCmblA7gzt3GU0d9kyZe+ThD/tycxIOASdoDGsQBetEdE3Y/8/ HbZ20TQfYyf22Etl0EpqtKwNRhxjhC2pQQIVOR3VhkMXOvN5LD4FFGSV4UgxIrNhf4d8 ZyaA== X-Gm-Message-State: AOPr4FW5b3r2zmAtZDrdzmlZxCYfv/DtwFFsaCIV5glFxTv45ggbqMEOYbMjmO2yVkl3DecK X-Received: by 10.28.54.33 with SMTP id d33mr22633272wma.62.1463463074839; Mon, 16 May 2016 22:31:14 -0700 (PDT) Received: from xps13.localnet (163.20.90.92.rev.sfr.net. [92.90.20.163]) by smtp.gmail.com with ESMTPSA id hm7sm958274wjb.41.2016.05.16.22.31.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 May 2016 22:31:13 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz , keith.wiles@intel.com Cc: dev@dpdk.org, pmatilai@redhat.com Date: Tue, 17 May 2016 07:31:12 +0200 Message-ID: <25696135.NHD1A2FuVu@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1460626956-12038-1-git-send-email-olivier.matz@6wind.com> References: <1455302184-48822-1-git-send-email-keith.wiles@intel.com> <1460626956-12038-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] mempool: reduce rte_mempool structure size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2016 05:31:15 -0000 2016-04-14 11:42, Olivier Matz: > From: Keith Wiles > > The rte_mempool structure is changed, which will cause an ABI change > for this structure. Providing backward compat is not reasonable > here as this structure is used in multiple defines/inlines. The deprecation notice must be removed by this patch. [...] > +/** > * Calculate the size of the mempool header. > * > * @param mp > @@ -254,9 +256,9 @@ struct rte_mempool { > * @param pgn > * Number of pages used to store mempool objects. A new parameter has been forgotten: * @param cs * Size of the per-lcore cache. > */ > -#define MEMPOOL_HEADER_SIZE(mp, pgn) (sizeof(*(mp)) + \ > - RTE_ALIGN_CEIL(((pgn) - RTE_DIM((mp)->elt_pa)) * \ > - sizeof ((mp)->elt_pa[0]), RTE_CACHE_LINE_SIZE)) > +#define MEMPOOL_HEADER_SIZE(mp, pgn, cs) \ > + (sizeof(*(mp)) + __PA_SIZE(mp, pgn) + (((cs) == 0) ? 0 : \ > + (sizeof(struct rte_mempool_cache) * RTE_MAX_LCORE))) Applied with above changes