From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B63C8A053B; Thu, 6 Feb 2020 15:56:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9279E1C11F; Thu, 6 Feb 2020 15:56:03 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 86FBB1C11D for ; Thu, 6 Feb 2020 15:56:02 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id s10so303547wmh.3 for ; Thu, 06 Feb 2020 06:56:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3UhyCpUER0o5XuGLlHw7E4n7GXfTK0PzvDVHBaQ6zrI=; b=jWJ3Unc+VoszoPvZ4zn0y0b6pYAH83tfFf8rpbmLmbteedqJe1hb2IhdrNLlFs1FE7 8hLmAL0z+khB4L0UwAu1VaI+jpdYIuZX/Gv8zBnI/g6bRyQc9LqDaGgkAAfI7uTOeiK3 QOelei+iSw6Yv4l3dqV3r6zEXJyDPJbA0DfKMd7qUmOK1vP6mpTEO89pxQmkI/D2g56l EKcft6oZCrn4s45YdDQvmrECRBWpr0LlhK1kWcJmCUKIggjwcPdAd4q4oiTi6oqGx39+ /yQc1IQiUa7KqibFaDj/JFD/YjecOKlC/fQQAxIkq93Sv6m4NZlApBhOKjrDPAMEj0sf 3kPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3UhyCpUER0o5XuGLlHw7E4n7GXfTK0PzvDVHBaQ6zrI=; b=Kpk1WX8kDFUqFD2iqOIEyVBYZoZX+qlbIgLHu5ZghuR/fHLK9/8REJF0GOYkmlYHEr a2b7rnO20RFrvsSHEkcb6OCKHpiDZq1SKIzbOcLpkCMli7hoZoNL2uQNav8NoSXnYbRD dXHn/Mv0pc9MN1aNGTUBNmwqWCC/9JgNsbcSrcrqioZruVw/G0rDHcnhq9sHKEr7l3ea ymNdbtDOKQNb6/xK19zda3ul19UmAwdmjTkxAoNztM27S+qlWdYjr+wdQeYD8IEDjnyS btI3dAheSvFXU2SumnMqGwSgae1tRGX62xRPK6FVbBQEaK4TDEowqJW/7Wj/ccN+SD1J S6Jw== X-Gm-Message-State: APjAAAX90J5smSjYgJw22IrCtrPwx/plbJOFAqih5uKBcoXrf+MbXgvn 4qqh2XMeVCYVWosLBIym4clj X-Google-Smtp-Source: APXvYqwsAClP89vmdXuM7k4P1ZyPOdoyYKzwQ8cl2yd9vJv69qbTUShU4M13WLZE1jdmSMoGOeRW5Q== X-Received: by 2002:a05:600c:214a:: with SMTP id v10mr5186590wml.182.1581000962239; Thu, 06 Feb 2020 06:56:02 -0800 (PST) Received: from [10.16.0.208] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g2sm4474190wrw.76.2020.02.06.06.56.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 06:56:01 -0800 (PST) To: Jerin Jacob Cc: Bruce Richardson , "dev@dpdk.org" , Anoob Joseph , Akhil Goyal References: <20200206142749.GA777@bricha3-MOBL.ger.corp.intel.com> From: Thierry Herbelot Message-ID: <256f5d9f-ca90-8946-64c0-319a886bff3a@6wind.com> Date: Thu, 6 Feb 2020 15:56:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/6/20 3:48 PM, Jerin Jacob wrote: > On Thu, Feb 6, 2020 at 8:06 PM Thierry Herbelot > wrote: >> >> On 2/6/20 3:27 PM, Bruce Richardson wrote: >>> On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote: >>>> Hello, >>>> >>>> When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx2 (on an >>>> Intel machine): >>>> >>>> git clone git://dpdk.org/dpdk >>>> cd dpdk >>>> make config T=x86_64-native-linux-gcc >>>> cd build >>>> vi .config >>>> => disable RTE_LIBRTE_IPSEC and RTE_LIBRTE_SECURITY >>>> make >>>> ... >>>> == Build drivers/net/octeontx2 >>>> CC otx2_rx.o >>>> In file included from .../dpdk/drivers/net/octeontx2/otx2_ethdev_sec.h:10, >>>> from .../dpdk/drivers/net/octeontx2/otx2_rx.h:11, >>>> from .../dpdk/drivers/net/octeontx2/otx2_ethdev.h:24, >>>> from .../dpdk/drivers/net/octeontx2/otx2_rx.c:7: >>>> .../dpdk/drivers/crypto/octeontx2/otx2_ipsec_fp.h:9:10: fatal error: >>>> rte_security.h: No such file or directory >>>> #include >>>> ^~~~~~~~~~~~~~~~ >>>> compilation terminated. >>>> >>>> This seems cause by f44e7163775537 ('net/octeontx2: add security session >>>> operations'). >>>> >>> Disabling parts of the build, particularly libraries, is always likely to >>> cause other build failures. I'm not sure we should, or even need to, >>> support the disabling of arbitrary libs in DPDK. >> >> Hello, >> >> On the other hand, there is no reason delivering unused code in a DPDK >> application: an application should be free to select its needed 'modules'. > > Just to understand the use case, What would be the downside of > compiling unwanted code? > In meson, it takes only jiffies to compile code and If we use, > -no-whole-archive then the generated binary will not be bloated, > Considering the case where "make" build system will be deprecated soon > and, for meson, I don't think, we are > planning to take the route of disabling the "core libraries". > > Could you share the real-world use for this? > My only concern is we can not make tons of #define in the driver code. > So, eventually, we end up > disabling the driver. Hello Jerin, Our use case is that IPsec is provided as part of 6WIND stack, not using the version from DPDK (we are using the crypto PMDs from DPDK). In any case, as the compilation of DPDK is (still) driven by a separate configuration file, it should be possible that some combination of options are disabled, and still DPDK builds fine. Thierry > > > >> >> Thanks >> >> Thierry >> >>> >>> /Bruce >>> >> -- Thierry Herbelot 6WIND Senior Software Engineer Tel: +33 1 39 30 92 61 Fax: +33 1 39 30 92 11 thierry.herbelot@6wind.com www.6wind.com Immeuble Central Gare - Bât C 1, place Charles de Gaulle 78180 Montigny-le-Bretonneux, France Ce courriel ainsi que toutes les pièces jointes, est uniquement destiné à son ou ses destinataires. Il contient des informations confidentielles qui sont la propriété de 6WIND. Toute révélation, distribution ou copie des informations qu'il contient est strictement interdite. Si vous avez reçu ce message par erreur, veuillez immédiatement le signaler à l'émetteur et détruire toutes les données reçues This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to 6WIND. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.