From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 449EA4240B; Wed, 18 Jan 2023 11:30:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F07F400D6; Wed, 18 Jan 2023 11:30:04 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 27E654003F for ; Wed, 18 Jan 2023 11:30:02 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id BB35B32000F9; Wed, 18 Jan 2023 05:29:59 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 18 Jan 2023 05:30:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674037799; x= 1674124199; bh=FYbBl715X4P5Kvo9+Q2ol2EyiPwi/DI7bAtEZg459S4=; b=T Pdv1H9UFPNI56Q0ZBGoOFDJ7we4i8mrrkrY7kGQCAKlPhn6D8EvMM601tiEovSjr RPmEECD1t4BTthJMB4y6QgKxgS9cXKEGO9TwNyReSq37KEwm2H8uw2k0uTCzzMtG 5LOCnxEsakEhBREqRjP7neCy7QgcPOuEMTBs3ddkdOhJ+rOQRA/vCOkGFhCIPD7A X9gQfb5KV9jShClRu2CdC1FogPmMX/PrHIdz2ry/zEsOXPKSTyWsD0umMt0/sX0P 6uEfwbsdao4OFhYqEeY4xX37K5GYuOJd7V4KwCdv2ZbO0k6VH2Y+pCSZcEwjR408 6gtW1p7zKpRwD6myYwh2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674037799; x= 1674124199; bh=FYbBl715X4P5Kvo9+Q2ol2EyiPwi/DI7bAtEZg459S4=; b=M 0cm2NPDLdr2gx2vq3JWciAVd/KLYf6B6ZxqffC3ankTKpDyj0/YOuTBfE/KaZwWB ymT8WUOkjpvHXuXRTcHOjzubxy4W7sZoN85IX2aM+F61YCuhm2eUMUXnbGS4uyBr R0ZyTb9UwVEp7yYT6oJKShf4us4xTtJVtiAM8rVouz0yAlH0T2hH9F1vg31aLMp0 tU+6CDOAzIskVBFh7hVpTMZ6a2O6ATdnxZ0yWYmN8uZK1fdXeB9MvS7fMzpaJ3XO gTYCie0FhjRMcTXIc5xBFotAya+AIuY3o8xyfzAWiSAO6m+Q1KGPxSAGJQnKWlHZ +dGPCA8exnhlZ5yk3ED0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtkedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Jan 2023 05:29:57 -0500 (EST) From: Thomas Monjalon To: Hanumanth Pothula Cc: Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, viacheslavo@nvidia.com, jerinj@marvell.com, ndabilpuram@marvell.com Subject: Re: [PATCH v5 1/2] ethdev: fix ethdev configuration state on reset Date: Wed, 18 Jan 2023 11:29:55 +0100 Message-ID: <2578112.bcXerOTE6V@thomas> In-Reply-To: <20221221020713.2803232-1-hpothula@marvell.com> References: <20221220200250.2413443-1-hpothula@marvell.com> <20221221020713.2803232-1-hpothula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/12/2022 03:07, Hanumanth Pothula: > Presently, on device reset, ethdev configuration state, > dev_configured, is not reset. > > On device reset, reset ethdev configuration state to make > sure device reconfiguration happens cleanly. > > Signed-off-by: Hanumanth Pothula A "Fixes" line is missing to show the root cause and help backports. > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -1629,6 +1629,8 @@ rte_eth_dev_reset(uint16_t port_id) > port_id, rte_strerror(-ret)); > } > ret = dev->dev_ops->dev_reset(dev); > + if (!ret) Should be if (ret == 0) > + dev->data->dev_configured = 0;