From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52F23A0C41; Tue, 11 May 2021 10:18:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C142240140; Tue, 11 May 2021 10:18:02 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 5B5B24003E; Tue, 11 May 2021 10:18:01 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B5AB45C0057; Tue, 11 May 2021 04:18:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 11 May 2021 04:18:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= JHm6zrVA97voRo1EsYERvLWf5NZpFeeEzb/Caodx9h4=; b=Ec7XmWelaPnYS6uv Sn7jIJNoSUYMY9oxTZH7qABkHB6WvI8vwPSHVoTZv/vwCWDvXjgVUawsU7nSnk8h p34BlEse2hSH9tX/L5e5v5Tsdja2HgRAf9Jjum/g91v07kwDj5WPh9Mj7mTcmSmS v7NLGDOy6LirbHBSD3nRO2Ue9E/Jxv45altPyhmNwlzJlwq5N4ilw7ynfs8G2JXT K5tDyk5GBqEOMx6WKWle3rDicE2TfDx5ZAldL8mhb78MLOg+TWmG2gVv9JqCHl1/ ff+MszWtpa+043+HQqmRztU86Qjx0lU3kwYAckGskHMoCeOQ3Fi43ywJUkSWNiHo xly0CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=JHm6zrVA97voRo1EsYERvLWf5NZpFeeEzb/Caodx9 h4=; b=AnFOhsHqCIJFaKqsa2IShJOTkXthNxXtGerQXV8JJhsDqioQer0CGbgKk 3RNR1bQpDXgcY5H0PjBnmxQCWz3oH02akueDQYd/k3Zb5Mv94/vH7UNYTuD20T9R eeFGhhTHUEKSaGz85JTr2wP2UP1tEbZaq20P2y+kziIxC44VH9U+d3tMRYic/w2C Baisxj0D44JiwpH1zcCoqJjGBdYMwg+i/b4jXYSKqRuVXSPX0yBAg3M84XqgoU6G 8Csus38xMWipCVa08PcnvKZbd9gMfnJV8O3nkJNmq0IHblmvGt0GijlfO6BpXu2r Udy9dcKkxvDVo2kcLIBweK8MW3ifg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehtddgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 May 2021 04:17:59 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk , Lance Richardson Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, stable@dpdk.org, talshn@nvidia.com Date: Tue, 11 May 2021 10:17:58 +0200 Message-ID: <2578949.o3yKfYDW1X@thomas> In-Reply-To: <20210508142753.114343-1-lance.richardson@broadcom.com> References: <20210507181025.84012-1-lance.richardson@broadcom.com> <20210508142753.114343-1-lance.richardson@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/05/2021 16:27, Lance Richardson: > For 32-bit targets, size_t is normally a 32-bit type and > does not have sufficient range to represent 64-bit offsets > that can are needed when mapping PCI addresses. Use uint64_t > instead. > > Found when attempting to run 32-bit Linux dpdk-testpmd > using VFIO driver: > > EAL: pci_map_resource(): cannot map resource(63, 0xc0010000, \ > 0x200000, 0x20000000000): Invalid argument ((nil)) > > Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers") > Cc: stable@dpdk.org > Signed-off-by: Lance Richardson > --- > v3: Use PRIx64 instead of llx to format offset in log message. > v2: Use uint64_t instead of off_t (off_t is unknown to Windows). off_t is referenced in drivers/bus/pci/windows/pci.c (for unused parameter) so it should be fine? If not, we could add it?