From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 398271C185 for ; Mon, 14 May 2018 03:49:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BADF42258E; Sun, 13 May 2018 21:49:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 13 May 2018 21:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=NIqbfJ9RV7Xcert+5ViZp+lRIO BqNXLqI5xQk1gKb1I=; b=fGKo78q8Mqp2ljgktUxS6g02mE/NBq3zL4Xid+qZWG opCsUO4HTq2JITpguWHG4HLxeC4KHpTqsICkiy1+84dDzV+wuBRSLG28CKTr3XZ1 qWe10FFaXPpoCos8iAqAlQCxG8WYWjvLpobTFfXzbuk0S2RdD4VsWQd6YVa0y82f M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=NIqbfJ 9RV7Xcert+5ViZp+lRIOBqNXLqI5xQk1gKb1I=; b=kmAi8uOQpJuOZJjn836eBx 5cX82hQdk3O2GMwlydNsIIJp1EwsBzGKKLX+L0QzBZXfZNLPU4XH7FklMR5l9QeK I65uWxEXXn++6BprAjVqBpK0U48+yAgyOArFT5/NDJwv5kRtcRhaWsjKb+4ZtnKu CthNWdhBBIfro4xQwFBfoXJUXU+7EQMtrBvDRR/ynMZB5Wa3eUUcm0BUcoP6XiW8 qkXKIWa5JDWvZh9APwB4WHD7jxC82H8ONQFJ0y5LtrOJ984O1UjPm2NpmiYvvRgK G3AtKV8Oj33HyHMMtacqUzucYN/sKjvNi3Z6qarjMnzvfKEQ2lCTI1njXEadCFhg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F4181E491A; Sun, 13 May 2018 21:49:53 -0400 (EDT) From: Thomas Monjalon To: Andy Green Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com Date: Mon, 14 May 2018 03:49:52 +0200 Message-ID: <2579149.bEE7AC6OuP@xps> In-Reply-To: References: <152609021699.121661.5295227351721865436.stgit@localhost.localdomain> <1896621.ibENEg8Kdi@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 08/24] rte_ring_generic.h: stack declarations before code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 01:49:55 -0000 14/05/2018 02:09, Andy Green: > > On 05/14/2018 07:44 AM, Thomas Monjalon wrote: > > 14/05/2018 01:21, Andy Green: > >> > >> On 05/14/2018 12:47 AM, Thomas Monjalon wrote: > >>> 12/05/2018 03:59, Andy Green: > >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > >>>> In function '__rte_ring_move_prod_head': > >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:76:3: > >>>> warning: ISO C90 forbids mixed declarations and code > >>>> [-Wdeclaration-after-statement] > >>>> const uint32_t cons_tail = r->cons.tail; > >>>> ^~~~~ > >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h: > >>>> In function '__rte_ring_move_cons_head': > >>>> /projects/lagopus/src/dpdk/build/include/rte_ring_generic.h:147:3: > >>>> warning: ISO C90 forbids mixed declarations and code > >>>> [-Wdeclaration-after-statement] > >>>> const uint32_t prod_tail = r->prod.tail; > >>> > >>> The fix line is: > >>> Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation") > >> > >> OK... people can just use git blame at the time they want to know this > >> though. > > > > No, we need it to automatically detect which commits should be backported, > > There is nothing automatic about that flow :-) > > It's "automatic after every committer did the work manually" you mean. Yes. In this case, I found it for you. You just need to keep it if doing a new revision. > > and in which branch. > > > > We also add Cc: stable@dpdk.org to confirm explicitly that is must be backported. > > In other projects this work falls on the maintainer(s). In DPDK too, the maintainers often fill this field (I did it for your 8 patches just pushed today). But we prefer when this work is done by the patch author :)