DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest
@ 2018-11-13 13:58 Pallantla Poornima
  2018-11-13 16:07 ` Pattan, Reshma
  0 siblings, 1 reply; 3+ messages in thread
From: Pallantla Poornima @ 2018-11-13 13:58 UTC (permalink / raw)
  To: dev; +Cc: reshma.pattan, david.hunt, Pallantla Poornima, stable

Power_acpi_cpufreq_autotest should not be run on VM and platforms
which dont have acpi_cpufreq module loaded.
Hence changed return as TEST_SKIPPED

Fixes: 0ea2dd4409 ("test: skip when required lib not available")
Cc: stable@dpdk.org

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
---
 test/test/test_power_acpi_cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c
index 22e541d65..6d637cc77 100644
--- a/test/test/test_power_acpi_cpufreq.c
+++ b/test/test/test_power_acpi_cpufreq.c
@@ -441,7 +441,7 @@ test_power_acpi_cpufreq(void)
 				"correctly(APCI cpufreq) or operating in another valid "
 				"Power management environment\n", TEST_POWER_LCORE_ID);
 		rte_power_unset_env();
-		return -1;
+		return TEST_SKIPPED;
 	}
 
 	/**
-- 
2.13.6

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest
  2018-11-13 13:58 [dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest Pallantla Poornima
@ 2018-11-13 16:07 ` Pattan, Reshma
  2018-11-14  3:49   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Pattan, Reshma @ 2018-11-13 16:07 UTC (permalink / raw)
  To: Poornima, PallantlaX, dev; +Cc: Hunt, David, stable



> -----Original Message-----
> From: Poornima, PallantlaX
> Sent: Tuesday, November 13, 2018 1:58 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Hunt, David
> <david.hunt@intel.com>; Poornima, PallantlaX
> <pallantlax.poornima@intel.com>; stable@dpdk.org
> Subject: [PATCH] test: fix to skip power acpi cpufreq autotest
> 
> Power_acpi_cpufreq_autotest should not be run on VM and platforms which
> dont have acpi_cpufreq module loaded.
> Hence changed return as TEST_SKIPPED
> 
> Fixes: 0ea2dd4409 ("test: skip when required lib not available")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>

Acked-by: Reshma Pattan <reshma.pattan@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest
  2018-11-13 16:07 ` Pattan, Reshma
@ 2018-11-14  3:49   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-11-14  3:49 UTC (permalink / raw)
  To: Poornima, PallantlaX; +Cc: dev, Pattan, Reshma, Hunt, David, stable

13/11/2018 17:07, Pattan, Reshma:
> From: Poornima, PallantlaX
> > 
> > Power_acpi_cpufreq_autotest should not be run on VM and platforms which
> > dont have acpi_cpufreq module loaded.
> > Hence changed return as TEST_SKIPPED
> > 
> > Fixes: 0ea2dd4409 ("test: skip when required lib not available")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-14  3:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-13 13:58 [dpdk-dev] [PATCH] test: fix to skip power acpi cpufreq autotest Pallantla Poornima
2018-11-13 16:07 ` Pattan, Reshma
2018-11-14  3:49   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).