From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B811D1BF4E; Wed, 27 Jun 2018 23:00:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 57793219C0; Wed, 27 Jun 2018 17:00:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 27 Jun 2018 17:00:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=NQtqDSblPt4YrvCWyS0hYIMfGp KeQzboIvtrYvGG43k=; b=MpE+lhY8XuBl55E9jdPWySoxdNAMHQvq4smDYdppIB BmlmRM7pI9zp6FmE2wZrkryRqcMelUdvr64rPGIpSsDY6y2Pr5F5upXXpkmcJKM/ 7+S6+2H0QZ9m9gDRkDvRY8qj66zcxzOsqe9NvbBTfi5kWlbkZ+9MXaDt0oWUA9D0 k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=NQtqDS blPt4YrvCWyS0hYIMfGpKeQzboIvtrYvGG43k=; b=I0q+Znzpb1dcGNEFwpyjxQ gVzgSPVMD+at2tYAwrCvUh/fuZhh75uQhSeyG5sDtmEf2FxJzvcJXAqP9rJQ4gCU cCc7uAUTTmX2zeHQ1cQD+9jPV5lU00iz/ChUgTpDuS29un3gSB+481gPSkz0L0w8 VQT2JQL+I3xMg7i8Q8YkCx4l6XvAHXmkQtNteayz6U56EQPbin1oDlmKcNSHNWLS fKBLr4gQg5PjP7a0otCNe1oknouwxe+218qTgxaRqqrWj9Z6BqT4uQWuMobE5sGc cAs1JiViIZ/ZQlO8mAXoD41P0/90Ky0Vx+tW9W8YiZxuczseY765iE6JdV0Y4Bnw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3D030E419D; Wed, 27 Jun 2018 17:00:42 -0400 (EDT) From: Thomas Monjalon To: Gavin Hu Cc: stable@dpdk.org, dev@dpdk.org, nd@arm.com Date: Wed, 27 Jun 2018 23:00:38 +0200 Message-ID: <2581181.jGqILcfPxU@xps> In-Reply-To: <20180625024913.17219-2-gavin.hu@arm.com> References: <20180619103657.19186-1-gavin.hu@arm.com> <20180625024913.17219-1-gavin.hu@arm.com> <20180625024913.17219-2-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v13 1/6] mk: fix makefile based cross build errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 21:00:44 -0000 25/06/2018 04:49, Gavin Hu: > From: gavin hu >=20 > The "-Wimplicit-fallthrough=3D2" option was introduced into gcc 7.0, it w= as > enabled when the cross compiler gcc is greater than 7.0, but for the host > side buildtools/pmdinfogen, if the native gcc is older than 7.0, or the > host cc compiler is clang, it should not be enabled. >=20 > The fix is to differentiate the host gcc Werror options from the cross gc= c. >=20 > gcc -Wp,-MD,./.pmdinfogen.o.d.tmp -W -Wall -Wstrict-prototypes > -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition > -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual > -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wdeprecated > -Werror -Wimplicit-fallthrough=3D2 -Dbbb -Wno-format-truncation -g > -I/home/gavin/arm_repo/dpdk/build/include -o pmdinfogen.o -c > ~/dpdk/buildtools/pmdinfogen/pmdinfogen.c gcc: error: > unrecognized command line option =E2=80=98-Wimplicit-fallthrough=3D2=E2= =80=99 > ~/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'pmdinfogen.= o' > failed make[3]: *** [pmdinfogen.o] Error 1 >=20 > Fixes: ced3e6f8 ("mk: adjust gcc flags for new gcc 7 warnings") > Cc: stable@dpdk.org >=20 > Signed-off-by: Gavin Hu > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Steve Capper Acked-by: Thomas Monjalon