From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B80A6A00C3; Wed, 2 Feb 2022 21:59:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C42B40688; Wed, 2 Feb 2022 21:59:36 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 25F3B40141 for ; Wed, 2 Feb 2022 21:59:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B319C3202322; Wed, 2 Feb 2022 15:59:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 02 Feb 2022 15:59:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=GrfIBvqKeaHiaP 2zvXJ7KYflFUJ1IWdFXGQOUk+XeO0=; b=NroCuqutaG/g32hk1rruHjvaoBPBqh RNMWv9ZOgnGCKikapBvXUxoRg95bqFeR0pwr78r8idMx/mUttg6hHMHiXipM4/dq fbSs6bBsIYfNJiZ08rMggh/mSzo6vG593u4PWfaq5atddD6BayVGdVG7wAK246mT jGJpW0ee+GY/uw6p8khGsHWRbvdbZ/vnRmU/b+M81M3lAEP42TEKPvB1oAcR5IoA XkcJjC5k3lO4/ihemSDJyOLSpjoxYNnjDekHS+1vMQyd3geVDceFX/NaWfpjgzbf 0Gg2NTcI0HE8LqfbjzxKE0AI8VCr4ond8PSLsMA/fxgtO3CgZi5u9cug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=GrfIBvqKeaHiaP2zvXJ7KYflFUJ1IWdFXGQOUk+Xe O0=; b=lN4LWpuU/JsjqYLrUARytF9sge6lUfzDvq88VejwQPJ7r/00I6norFtzo At0A77tdR1jB6AS3hqdxnaR9OdlMid8PkXAiFY4Jp9i7rwem2wSARuXvQaDJJvOi D0rlaN25uArhGWZmSW/WQTobKWQ3mwoMiQ31sdQPE2n4Dj84b7qDNfiaPZS4aDSe EuZB11VuYT+ZuNFH+ENlc/Ugts3gsvrxj3FdSeeNCj2JgNJ7ziWkek9rPeLcjtEj 1Exj1HYfmWkbp8d3RFQ+UZYaIcBF9t0gIQHjn4QwB0Rgl+QWnaheC9QFGFkwEoq6 o0I8BlVHTA+62EfrVPzoT5CvEVq1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeehgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Feb 2022 15:59:31 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Bruce Richardson , david.marchand@redhat.com Subject: Re: [dpdk-dev] [PATCH v2] build: add definitions for use as meson subproject Date: Wed, 02 Feb 2022 21:59:29 +0100 Message-ID: <2582255.KRxA6XjA2N@thomas> In-Reply-To: References: <20211103221205.63175-1-stephen@networkplumber.org> <20211105172213.103988-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/11/2021 19:11, Bruce Richardson: > On Fri, Nov 05, 2021 at 10:22:13AM -0700, Stephen Hemminger wrote: > > +# If DPDK is being built as subproject then define > > +# variable with the dependency convention > > +if meson.is_subproject() > > + libdpdk_dep = declare_dependency( > > + version: meson.project_version(), > > + compile_args : pkg_extra_cflags, > > + dependencies: dpdk_libs_deps, > > + link_args: dpdk_extra_ldflags, > > + link_with: dpdk_libraries > > Minor nit, but the dpdk_libraries is always the shared libs, it's > dpdk_static_libraries in the static case. Since elsewhere you switched on > the "default_library" value, maybe you should do so here. > > Personally, I'd tend more towards having two new vars, "dpdk_libs_deps" and > "dpdk_static_libs_deps", and then define two global dependency objects: > "libdpdk_dep" and "libdpdk_static_dep", to make it easy for subprojects to > pull in the one they want. I don't want to merge this patch without having an answer to this comment. Stephen, what do you think?