From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0E8B71B1BC
 for <dev@dpdk.org>; Fri,  6 Oct 2017 01:41:03 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 9E8F12093D;
 Thu,  5 Oct 2017 19:41:02 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Thu, 05 Oct 2017 19:41:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=1wB1T54UpUNfpJl
 8b8myQqi7sazHz4PLdHrUc1qHXx4=; b=VgQrl0GDTqpcIlw6bwzcsH9EhEwUBOi
 Y07rs9QQVa3RoFb5WvXze7TUyX6FO3FAYA8xLkBPRrBEmRFLvKHEqdyJwXOeyzS/
 dFZVba7EAs/w7ipNctUcFlpQD6HvSgIfNxkpzTM/pZEMpmlpbN7s9la8JYsWfd2m
 2z/weCkQ6Mlw=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=1wB1T54UpUNfpJl8b8myQqi7sazHz4PLdHrUc1qHXx4=; b=XAdU40rF
 qn+tI1JElppiLWo2DwAmwsK5Hyih7VgCz2YtPZpGkNH6Id2oQyuthfXELbZmoC/z
 2nyKhzRNFwj/GX6aE0oAS7/d+eT3ZE2cQR01MUy1wb2o6c4zh+dn2rY6gUdMl2o+
 CY2UVQFn2YgxYhYEA3kAHrRq4GmyiPNfX6O2+vJaieunHLB77Syzp1+hoVFmIsAR
 XWXDWwE+Fzyv670muJfE2vk/My39I14v1j1br4H9L2vkJPJNdKXjpIw74DshJ/Hi
 LptBwct7VNNLTAMf8CazzzryfgYdDFFAnNH8z6LMn2NZbbyA2WypTP4FyhzSLABT
 wxG974bENzY9tA==
X-ME-Sender: <xms:DsPWWeVqbQjFfvD24uWKvEvJzscfseNy2371lpQ8YVccz5bFJCJoSg>
X-Sasl-enc: YGi+W/6GKUln8vb9kzUOaDwm8TqozwDfakTib228wbC9 1507246862
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 531077FA70;
 Thu,  5 Oct 2017 19:41:02 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, anatoly.burakov@intel.com
Cc: dev@dpdk.org
Date: Fri, 06 Oct 2017 01:41:01 +0200
Message-ID: <2584395.73f1Oakct5@xps>
In-Reply-To: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com>
References: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: fslmc bus need vfio enabled for non PCI
	case as well
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Oct 2017 23:41:03 -0000

13/07/2017 13:48, Hemant Agrawal:
> In case no_pci is configured, fslmc bus will still need the
> the vfio to be enabled.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> +#ifdef RTE_LIBRTE_FSLMC_BUS
> +	if (!vfio_enabled) {
> +		if (!vfio_enable("vfio_fsl_mc"))
> +			vfio_enabled = 1;
> +	}
> +#endif

It seems to be a hack.
VFIO is not only PCI.
Why --no-pci is impacting VFIO?

Anatoly?