From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
 [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 1FEA3B362
 for <dev@dpdk.org>; Thu, 24 Jul 2014 16:52:46 +0200 (CEST)
Received: by mail-we0-f177.google.com with SMTP id w62so2821885wes.22
 for <dev@dpdk.org>; Thu, 24 Jul 2014 07:54:14 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Vo97gqbjZWVwJU7oaQbqJxKGDlbvgRtAznLA79G3S+o=;
 b=dKYGJyjF35udU5JeP/+xpCFNoQBOZefiHUsXVcZ2MUwRygzfvT2HlRxcDEB31zHq9i
 KEACgAGonqxbC/UmZWbVZrVOvxlYcVe0b4CHNFXZTv+YpuTTvpMDxB+aHwrOiMuwQF/h
 VEmk2pcN7j54Es4/B1bEB5ij3/+1usaa7OGzgTXBOTHFAaBjQRxqnTq71einjfn3UjDF
 +KJXHeP25hpoJ96sX4hpU/IGWgoLQys2jymZ6J1qCkx096tMp7rohJDI3YGK0VWCDPad
 1Nzel8LAhCEn20ykKh1NbXd2A1+B0lBEvFa+2xXgzb9Mt+3E2X9x/Skkflci3Qdd48rc
 MkSA==
X-Gm-Message-State: ALoCoQkp4T3dLGbJbbnSi4OB3C/TQqhofra5043JW1CB/gh93u62S1y8FFub7qbcmTzHxm6UljNQ
X-Received: by 10.194.191.131 with SMTP id gy3mr13310795wjc.108.1406213654480; 
 Thu, 24 Jul 2014 07:54:14 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id go4sm16494504wjc.39.2014.07.24.07.54.12
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 24 Jul 2014 07:54:13 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Patrice Buriez <patrice.buriez@intel.com>
Date: Thu, 24 Jul 2014 16:54:03 +0200
Message-ID: <2585103.SGNXcBzLTL@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )
In-Reply-To: <1406212131-22314-1-git-send-email-pablo.de.lara.guarch@intel.com>
References: <1406212131-22314-1-git-send-email-pablo.de.lara.guarch@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fixed compilation error on Ubuntu 14.04
	LTS (kernel 3.13.0-30.54)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jul 2014 14:52:46 -0000

> Unlike RHEL_RELEASE_CODE, there is no such UBUNTU_RELEASE_CODE available out of
> the box, so it needs to be crafted from the Makefile
> Similarly, UBUNTU_KERNEL_CODE is generated with ABI and upload numbers.

It's quite amazing to see that Linux distributions do backports and do not
provide a way to check them.
Anyway, thanks for the fix.

> +ifeq ($(shell type lsb_release >/dev/null 2>&1 && lsb_release -si),Ubuntu)

Why not this simpler form?
$(shell lsb_release -si 2>/dev/null)

> +MODULE_CFLAGS += -DUBUNTU_RELEASE_CODE=$(subst .,,$(shell lsb_release -sr))

Or you can use | tr -d . instead of subst and keep the flow from left to right.

> +UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature |cut -d- -f1,2)
                                                                        ^
                                                         space missing here

> +UBUNTU_KERNEL_CODE := $(subst -,$(comma),$(UBUNTU_KERNEL_CODE))
> +UBUNTU_KERNEL_CODE := $(subst .,$(comma),$(UBUNTU_KERNEL_CODE))

Would be simpler with | tr -d .-

-- 
Thomas