From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] PCAP PMD fix: pcap_rx_queue/pcap_tx_queue should store it's own copy of name/type values
Date: Tue, 12 May 2015 12:30:37 +0200 [thread overview]
Message-ID: <2589343.PLMJveI5zI@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2F16E8D@IRSMSX103.ger.corp.intel.com>
> > pcap_rx_queue/pcap_tx_queue should store it's own copy of name/type
> > values, not the pointer to temporary allocated space.
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> Acked-by: John Mcnamara <john.mcnamara@intel.com>
Applied, thanks
Please note the new name for this commit:
pcap: fix storage of name and type in queues
It begins with the lowercase name of the PMD,
then a verb in imperative form and a short summary.
The verb should be "fix" in case of fixes.
Ideally, the bug (and its consequences) should be explained below.
https://github.com/erlang/otp/wiki/Writing-good-commit-messages
prev parent reply other threads:[~2015-05-12 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 14:32 Konstantin Ananyev
2015-04-28 14:06 ` Mcnamara, John
2015-05-12 10:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2589343.PLMJveI5zI@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).