From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 8E2D2376C for ; Tue, 12 May 2015 12:31:22 +0200 (CEST) Received: by wicnf17 with SMTP id nf17so8707166wic.1 for ; Tue, 12 May 2015 03:31:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=sKhbfbBcWTslcQi2A5imvBm2fQaHvJoz5/u1Ag3ZBZU=; b=kae27Vg+H2X4iRuxwqnoPhsARbB/9ssF47EobVLiQ23YTCi0RvogOqOjyapEwKRu6o WJM94U+qnFoiBZQNDOBm1Rc1a3tpIkWVlgvFKe7Gf5UyOOOEgD28Y/xscB0H3xcWTPP1 SrOb4zqExjv0buZcu0nc03G66H0o5JXogLrF8FA8ZAvm44dZatfc5b+RfuaRPTKQNbtr RoTndW+iWkgTtMSoUaG8n9ZH+6c8E3HBhHPxNYkj1FRRk9a2E3q4ybngc3AkY3qk/1nI S3Mnlf7yTgVWEYSDpElLLx9kDU9oTM/xdc0rFBGTrl7JmzAqIlRFVW5f486rt4umVS5n 6Msw== X-Gm-Message-State: ALoCoQldKbE0/iTBzfqFgskwwUmIjPQKw7la5sq2fZr6yVrSSNBi0U/PHh+Okdp8T0DL9WEd6gtE X-Received: by 10.180.74.208 with SMTP id w16mr3931346wiv.31.1431426679437; Tue, 12 May 2015 03:31:19 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gw7sm1821064wib.15.2015.05.12.03.31.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2015 03:31:18 -0700 (PDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Date: Tue, 12 May 2015 12:30:37 +0200 Message-ID: <2589343.PLMJveI5zI@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: References: <1429799568-19899-1-git-send-email-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] PCAP PMD fix: pcap_rx_queue/pcap_tx_queue should store it's own copy of name/type values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 10:31:22 -0000 > > pcap_rx_queue/pcap_tx_queue should store it's own copy of name/type > > values, not the pointer to temporary allocated space. > > > > Signed-off-by: Konstantin Ananyev > > Acked-by: John Mcnamara Applied, thanks Please note the new name for this commit: pcap: fix storage of name and type in queues It begins with the lowercase name of the PMD, then a verb in imperative form and a short summary. The verb should be "fix" in case of fixes. Ideally, the bug (and its consequences) should be explained below. https://github.com/erlang/otp/wiki/Writing-good-commit-messages