From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C6886A0547;
	Tue, 26 Oct 2021 18:07:43 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8B8C840E0F;
	Tue, 26 Oct 2021 18:07:43 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A7927407FF
 for <dev@dpdk.org>; Tue, 26 Oct 2021 18:07:42 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 3CB075C00AB;
 Tue, 26 Oct 2021 12:07:42 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Tue, 26 Oct 2021 12:07:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 FRkoCeAhgArqP//CGc6/piAcczvQfXYjmOk36o7Lo5U=; b=K5sO0DL0Sk/sEbtQ
 C4Zr9TBkqSjPpE0pBJQvlcjke7JHa5a8L9QlxE3aBcIA+JLW2PPsKt9NTb/UrxbE
 y5AQtzvJqF5JE5YE5Iq2fkbLANHceVcI/CSmVneGNLgIhw9jkbF7U1ne0VUMjaV6
 LWn4QjE2seFg1OTgMAu6S2Q+i4ERx+0vU4YHfFZmjAAK1MVJtsla0Jb6YjnNCOP3
 uHCupW1BGGsQtTXIGGHBuqBDqgSTjYTdFqOTNPloBYQ3O4ggs97Z2hCaVx8K9wxV
 fq3nV+eINXAa8BRJoMrfy19T+DgpzWwoEmgQP2gQVWp9my2xaCkHXRhTS6NRe40M
 e35ivg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=FRkoCeAhgArqP//CGc6/piAcczvQfXYjmOk36o7Lo
 5U=; b=YBfLP1yTXHRTb78jMPhD91X1Ua2GBfZ+fCyuQXbaxD/y+Mk5BqnArRAtb
 G0OdjCm3w5DKemnai6EdxoBMytGVBUig6QyYSqze99XSCy8HyURp45Eq/KsvjkVU
 5ok9uC+rihDiBgtE/CfrGKoaRQe0l4yYn17MHvtQyoNq5ifqpaY1O+Zid+cgwEAp
 Vab7Y2K+ywE/IV/mIlQp+q0eXO5jah7d0YHrlTdOd3/UPoG7RKYH/7ddLSLLFh9A
 k+6vsGd1fiC0gsUcc5bjLvT4/ith3bMInDY/fRZ715cOoSDi4YMXYvlIygrh/cmz
 QHYrU66FT7wFssV2dQFwEA0R22gEA==
X-ME-Sender: <xms:zSd4Ydm-_Kt9-XP98PBVJRtk1UKo9v-4RIvciluh4hrpFmr7NL8SYA>
 <xme:zSd4YY1UFrR52pDiKMzUtKkC3rdw6fQGbvuRDQMhge4_w0oiJKPKU4vLSajouhgd9
 cbL48ORPBMr4j_nqQ>
X-ME-Received: <xmr:zSd4YToG1ezO8E9V2wPwxzL_N6bbmn5L0hoI_4v1YqHT73tb5z7m1opMDgauz5brcnei9VjlUg5srz19ukCi2tnnRg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdefkedgheegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:zSd4Ydkup4iYuDnv0zBvgD9QdfU5iReU_eFwRyAn0jHSQD3LQ5wpxQ>
 <xmx:zSd4Yb2slf0iN5UmbCujPfDZsC9H7hvsPKTqWPgYp5NXVt3rKh3ZWw>
 <xmx:zSd4Ycv2DherH7FiY8cZeJGe-H8p5TbuWT5Z82WZnxNtSfOVIOUJfg>
 <xmx:zid4YVqMayoehWRw4aMtgzXA-GKlKZ6wY4cmv4uprkl7hHijzPmBbg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 26 Oct 2021 12:07:40 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Aman Kumar <aman.kumar@vvdntech.in>
Cc: dev@dpdk.org, viacheslavo@nvidia.com, anatoly.burakov@intel.com,
 keesang.song@amd.com, jerinjacobk@gmail.com, konstantin.ananyev@intel.com,
 bruce.richardson@intel.com
Date: Tue, 26 Oct 2021 18:07:39 +0200
Message-ID: <2589524.vx9lx3NToN@thomas>
In-Reply-To: <20211026155645.246783-2-aman.kumar@vvdntech.in>
References: <20211019104724.19416-1-aman.kumar@vvdntech.in>
 <20211026155645.246783-1-aman.kumar@vvdntech.in>
 <20211026155645.246783-2-aman.kumar@vvdntech.in>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 2/3] doc/guides: add dpdk build
 instruction for AMD platforms
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/10/2021 17:56, Aman Kumar:
> linux guide updated with AMD platform related build
> instructions.
> 
> Signed-off-by: Aman Kumar <aman.kumar@vvdntech.in>
> ---
>  doc/guides/linux_gsg/build_dpdk.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst
> index 0b08492ca2..3110448467 100644
> --- a/doc/guides/linux_gsg/build_dpdk.rst
> +++ b/doc/guides/linux_gsg/build_dpdk.rst
> @@ -113,6 +113,10 @@ The instruction set will be set automatically by default according to these rule
>  To override what instruction set will be used, set the ``cpu_instruction_set``
>  parameter to the instruction set of your choice (such as ``corei7``, ``power8``, etc.).

All possible values are not documented here.
If you want to mention znverX, I suggest just adding znver3 after corei7 above,
and remove the lines below.
Note: such change should be squashed with the meson change.

> +To build dpdk for AMD Zen CPU based platforms, pass ``-Dcpu_instruction_set=<znverX>``

s/dpdk/DPDK/

> +to meson when configuring the build folder initially. Supported options are znver1,
> +znver2 and znver3.

You can start a new line when starting a new sentence.

If you want to document AMD platform, you can add a file in
	doc/guides/platform/
For describing tuning on Linux you can do the same as
	doc/guides/linux_gsg/nic_perf_intel_platform.rst