From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John McNamara <john.mcnamara@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] eal: fix Wbad-function-cast warning
Date: Tue, 17 Mar 2015 00:29:23 +0100 [thread overview]
Message-ID: <2590049.SJhoNc6m2k@xps13> (raw)
In-Reply-To: <20150316175217.GE16238@hmsreliant.think-freely.org>
2015-03-16 13:52, Neil Horman:
> On Mon, Mar 16, 2015 at 05:05:06PM +0000, John McNamara wrote:
> > Fix a warning when the rte_common.h header is included in a compilation
> > using -Wbad-function-cast, such as in Open vSwitch where the
> > following warning is emitted repeatedly:
> >
> > ../rte_common.h: In function 'rte_is_aligned':
> > ../rte_common.h:184:9: warning: cast from function call of
> > type 'uintptr_t' to non-matching type 'void *' [-Wbad-function-cast]
> >
> > This change fixes the issue in rte_common.h by using the RTE_ALIGN_FLOOR
> > macro to get the aligned floor value with generic type casting.
> >
> > Also removed the rte_align_floor_int() function and replaced it with
> > the RTE_PTR_ALIGN_FLOOR() macro.
> >
> > Signed-off-by: John McNamara <john.mcnamara@intel.com>
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks
prev parent reply other threads:[~2015-03-16 23:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 12:56 [dpdk-dev] [PATCH] " John McNamara
2015-03-16 13:19 ` Neil Horman
2015-03-16 15:04 ` Mcnamara, John
2015-03-16 15:45 ` Neil Horman
2015-03-16 17:05 ` [dpdk-dev] [PATCH v2] " John McNamara
2015-03-16 17:52 ` Neil Horman
2015-03-16 23:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2590049.SJhoNc6m2k@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).