From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 02661378E for ; Thu, 16 Feb 2017 09:53:36 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id v186so60735596wmd.0 for ; Thu, 16 Feb 2017 00:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=42Dm/+aSTXkYLj0ieXfbeNvnIa/Eu98ljzKUZXBWFhk=; b=VwjgmfX0Vvge7sQCWi6X0a/I1HXbyEbILYAelKEzL3au74gTjJlQ6dnIgiEqmYj7NC gTygg0Gm7XC5KWSoUCkHVzGpWLTVmL4yBlFpIsWPIjS5xelxbStfZcaEuBr0/atQSrHx 2OaCxr+/Bv1Ynv3ddYn4ml8HOyUM4+wXnMX6wbfoTVhGJ2DbAv6o2J9ALxTGaSxQLjjw afMiM0LI4ryffJjsecAZ7/KMqVaNZ30x5yeUAIIzrRWM4huLfu1IhD1iNS8Bc4nyXn6j Mb1W6nL1LU2qk+8elpX8QLcA+V88AAOIOCFaX9D7uHEsmCvtcuDCkYkQ3L9otESWaUSh WLoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=42Dm/+aSTXkYLj0ieXfbeNvnIa/Eu98ljzKUZXBWFhk=; b=d3BbBLL+sMKXo2y5YhNmuwjXLcXRvKx6TRoeFpON+dhCMnKUqktZQLT75E3h1o8ZK5 ZSevKuLh88HjMK951tuNts2gKwZCMLR1W2HH0hav/ujWBM8NiqPYDGD8qOLGbZPxkoY3 lj4+lPZrX8Qz4oSNJaiudLHRfUrPcfGLYD1oVUvq9TwxWPnrlrp95hThunUBh62wcL+x yx5CjMwXk9waQVYJ5vqL0c7rRXgMq/e4572kM83vFxC8boOpDWVoWjeNTes2vi4gfY0F 1zdaq4gEEUDBbvw4DUac5qDn/RUfMAUZj/w70avUpvxzkloZ0t7awlYj4xT2fW23WYOq qA2Q== X-Gm-Message-State: AMke39lmICK7GwwIpRdbzxdnVZo6cHrvzN7v+3//FzIsypxPpv21XVha95+OqCqCgpy7tY/t X-Received: by 10.28.44.66 with SMTP id s63mr1257881wms.77.1487235216800; Thu, 16 Feb 2017 00:53:36 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d2sm7958398wrc.66.2017.02.16.00.53.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 00:53:36 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Bruce Richardson , John McNamara , Keith Wiles Date: Thu, 16 Feb 2017 09:53:35 +0100 Message-ID: <2590637.Rj3BpoAWc4@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20170214151326.7554-1-ferruh.yigit@intel.com> <3106919.K5kYvNu2Ff@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 08:53:37 -0000 2017-02-15 17:30, Ferruh Yigit: > On 2/15/2017 4:58 PM, Thomas Monjalon wrote: > > 2017-02-15 15:26, Ferruh Yigit: > >> +.PHONY: test-buid > >> +test-build: > >> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig > >> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test > > > > Why not rely on default rule below? > > > > # all other build targets > > %: > > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig > > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@ > > > Because generic rule is using "rte.sdkbuild.mk $@" rule, > for unit-test, $@ is test-build, but sdkbuild rule is "test" > > This can be solved with adding following to sdkbuild.mk: > > --- a/mk/rte.sdkbuild.mk > +++ b/mk/rte.sdkbuild.mk > @@ -72,6 +72,9 @@ clean: $(CLEANDIRS) > $(Q)$(MAKE) -f $(RTE_SDK)/GNUmakefile gcovclean > @echo Clean complete > > +.PHONY: test-build > +test-build: test > + > .SECONDEXPANSION: > .PHONY: $(ROOTDIRS-y) test > $(ROOTDIRS-y) test: > > > I can update if you think this is better? Yes it seems better. Or you can just rename test into test-build in rte.sdkbuild.mk.