From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6523F41BE7; Mon, 6 Feb 2023 08:31:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A5FB40E03; Mon, 6 Feb 2023 08:31:43 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 6E3D640A7D for ; Mon, 6 Feb 2023 08:31:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 3825B32001FC; Mon, 6 Feb 2023 02:31:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 06 Feb 2023 02:31:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675668699; x= 1675755099; bh=3VHFIFn9nuzIFDiQyvs3zkORtpduJdV8PICeIO4662w=; b=c sm7gg90ssDy/JUtJ6V/e/kvucJepPhU7cU16OtOXfWPY6/l986x9MVcq6KZ8pxHi /RE2F34GD+ZqIbMah8h2loTToHRIx8j6bRSAOvNLmzqP0U2pk7PGOwjMDCUnX0zm r0CspIwOKTBkdwmUOx75Z4Qvmv6qLYMwtkX+lhCy48JjsoAH6+bqqQMcdnJibb2r tC3Q7VEnCl0AG6VMD8Q0+z1MzPnfdJX4RnFBib7UEP9hkIls6IDbSJBYv5feiQxq PTaeDH3hSKTgAZ7tgIdck/y+8ia3JsAorzpvjMYAEIkNNq8wwI+NqRD7CZ/4R9RG a++uCkLRdSf66rjkR4gZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675668699; x= 1675755099; bh=3VHFIFn9nuzIFDiQyvs3zkORtpduJdV8PICeIO4662w=; b=l STi3Hxg2UB2HNiqKUVSseeTIK1BuQHkHDf9TI01Mf5IALgY+TQZ1aX3JcPT9cmPc R03X0TwnGc6Ualu3WZm70tTwWFBUqXR10ct8XjnWLqk8tUaXe85JBDbKBaQmFKAa cgrF/yP1nmJiEdTyLiLg340iPcXQ8wVshO2PKqiX0KemAoM672QfCMKlKYg5J9i9 oyff0Po9omtAFN9Mq2QwfZ41sKdXQkqXEOw1FyrZT/1cK1k22aufT1o7o1keoZzS Z2Eg4xslOvkjlJchlyB1sy0dgCqwz6ItU2yovy+JyJWOkT//P0to4QPXMU3+FNGc XUQe8nbyHVlyU6CrvRElg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeghedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 02:31:38 -0500 (EST) From: Thomas Monjalon To: Tanzeel-inline Cc: olivier.matz@6wind.com, dev@dpdk.org, Tanzeel Ahmed , ferruh.yigit@amd.com Subject: Re: [PATCH v2 2/2] lib/net: added push MPLS header API Date: Mon, 06 Feb 2023 08:31:37 +0100 Message-ID: <2591829.k3LOHGUjKi@thomas> In-Reply-To: <1671319918-44725-1-git-send-email-tanxeel1.ahmed@gmail.com> References: <1671299771-10261-1-git-send-email-tanxeel1.ahmed@gmail.com> <1671319918-44725-1-git-send-email-tanxeel1.ahmed@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/12/2022 00:31, Tanzeel-inline: > The mpls hdr can't be const because the bs bit is updated by checking ether type. > > v2: > * marked experimental > * trailing blanks removed > * space after /* and before */ > * updated to bracket cuddle style > * changed rte_memcpy to memcpy This patch is a change on top of the v1. The new version should include all changes. Also you should explain why you add this function. I'm not sure it should be inline.