From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CAA0A052A; Tue, 26 Jan 2021 16:31:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FCCF140FB5; Tue, 26 Jan 2021 16:31:43 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 914EF140F88 for <dev@dpdk.org>; Tue, 26 Jan 2021 16:31:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id B574D5C00AB; Tue, 26 Jan 2021 10:31:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 26 Jan 2021 10:31:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= x7KYipluWQDuGSGdV7z8tZCaR8TDon68U65SC1VLhQQ=; b=uDrTG0uxv/gLxYx8 afte2IDep+XXJLfUGGn1vqvouF/UiwGM41hZwV5DgoNw2x6ANbhvYuKf2/7E1YeM 54rOAkPvql1rXD31SKc5pVMfXaOHvkQkJbiE17qeG58c7UvcEwsLVTngxwtU43lD Y4YQhtZS2opu/Hrc0swouyYAQr7WAMGo6S5ERhgOl3p1uXNkhzwXt6qe62RMyo16 Y75OkoJ6VYmIdZRJrhmNKELe28G0Wo1SXU1VDuta30ttaYgpycY9YSh9D0aZroDC GQbV1pzFP69wKHeqicqUAuXJHl84HLNRhdcr8+X52+22U4nHX56iiBwU7KHG9MTU P25Jnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=x7KYipluWQDuGSGdV7z8tZCaR8TDon68U65SC1VLh QQ=; b=l6XJk8EfdWf3dnz5BrBDPpZkbAnRZpQIgRtDcVffzBUqxbCWfy3Yl10Sa CyR1nIYGuxeh5GCxKZtoZNyxjiXxkGm0oFETPSA6YB/SfX01cKRg7MnlJxK+YVrh kgVOr+9mfsd9xpkaFclBbg028Qcq6LnyJL4BvmEmpwqZrTlUi4xB0/6/tqZxRsyY 52IZ+KKm/sOzjcGblLfMTwcQEChdRDJ8esdb8BpuRjVJ1hTHnbQnRj0YIqfTHfwu PktgVK6sqXI+hLoGfZ87j73Rn1coSXQakf7dd82ECA4yYWylu4nUlqQvgTC9Koza oiyQTI1sCs2jxeEOHsSmtb114UtNQ== X-ME-Sender: <xms:2zUQYGMS1-U5vX0N2nF_kI94GnQfaJIp0MIP0fe0eTFf9A_jy41uJw> <xme:2zUQYE_iUSyjE36F0CBPjcpiw0GR4ZFCApjCQlOPZ6QBakBny72Fsw-V_e5ybmvd_ seqpI2rd2pGGXXOqQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdeigdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:2zUQYNStZIpKOcyRb6ZCmQw5OKGc7FDneQTq_gBLbUjNyamyOd8nWQ> <xmx:2zUQYGvnXb1puPI0NkSduxHYB63oeGBEWb6zPet7gBUVUgMTCumAFA> <xmx:2zUQYOduzVtw2YEbOHaxx7BJ-OH8pJxq35ZkewyJD3k3Foa1j5B1Vg> <xmx:2zUQYCFVpL6dnStVQs1Aq7vq3eocXKQpt9rEa55fmIfS9EgrfILIyQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E975108005B; Tue, 26 Jan 2021 10:31:38 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: David Marchand <david.marchand@redhat.com>, Bruce Richardson <bruce.richardson@intel.com> Cc: dev <dev@dpdk.org>, ferruh.yigit@intel.com Date: Tue, 26 Jan 2021 16:31:36 +0100 Message-ID: <2592228.fJoplo53l3@thomas> In-Reply-To: <20210126143925.GC239@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210126142402.GB239@bricha3-MOBL.ger.corp.intel.com> <20210126143925.GC239@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 26/01/2021 15:39, Bruce Richardson: > Removing the ALLOW_INTERNAL_API is probably a good idea, but it does indeed > throw up the errors with clang - but not gcc, which is strange. The > offending headers seem to be (initially): > > * rte_ethdev_vdev.h > * rte_ethdev_pci.h > > Are these public header files, or should they skip header checking - and > installation - as internal-only? They are helpers for the drivers, so should be internal.