From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH] check-spdk: check that tag is on first line
Date: Wed, 05 Nov 2025 23:37:11 +0100 [thread overview]
Message-ID: <2592245.3CdzvNlvnA@thomas> (raw)
In-Reply-To: <20251105222827.904627-1-stephen@networkplumber.org>
05/11/2025 23:28, Stephen Hemminger:
> For C files the tag needs to be on the first line.
> Add a check for that.
Good idea, I didn't think about this script when fixing files.
> -echo "total: $missing_spdx missing SPDX, $wrong_license license errors, $warnings warnings"
> +echo "total: $missing_spdx missing SPDX, $not_first not on first line, $wrong_license license errors, $warnings warnings"
Can we just integrate it in warnings?
By the way, it would be nice that the quiet mode does not print this last line if all is OK.
next prev parent reply other threads:[~2025-11-05 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 14:20 [PATCH 1/1] move SPDX tag on the " Thomas Monjalon
2025-10-31 14:55 ` Morten Brørup
2025-11-05 21:31 ` Thomas Monjalon
2025-11-05 22:28 ` [PATCH] check-spdk: check that tag is on " Stephen Hemminger
2025-11-05 22:37 ` Thomas Monjalon [this message]
2025-11-06 1:22 ` [PATCH v2] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2592245.3CdzvNlvnA@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).