From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id E79F4590F for ; Thu, 17 Jul 2014 11:34:58 +0200 (CEST) Received: by mail-wi0-f172.google.com with SMTP id n3so7602010wiv.17 for ; Thu, 17 Jul 2014 02:35:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=AnjjvtBcy4+81h3oW8W+pGdLVJdfR+yrv2NgnPqkduo=; b=Kelz0d01MXQoROs14frTbIwuzCH8L1+pJnK5lbbMZxjZdbirW0JQRTYUFVjCsW7r4t OSOQ3R6rAce9lws26ZdYHltT/h7+vB6PKvzFU1xzZ4WDHyHYBNBD5ygdfYk0Um+W+ztr 3Xp8J0ws6w1KClsftf7npbN0iZLaz+gT0Fm/ot+buT3lcLOdTh05sSa7gZE5PH3aKTDA PMBAQirZmHhTDkpBY4fI8ek9hd5p1psbfATtrm8DfrRbPw+3GuoRo1M5x+d9aBTnam43 CmAiE1sb7vFBx9LhWVP5/4L1P0asRFyDOsQJuOXTlhE5ry9y1QDvzEOeuUqLF0Vjedyd IcMw== X-Gm-Message-State: ALoCoQn+7n1zd5KChBqi0WzZ+gMRZO9TslE+N6IyP6n6cXSY+0rxr5jDPI7dkU2G63jHR2MwO7hb X-Received: by 10.194.158.164 with SMTP id wv4mr2290405wjb.124.1405589754076; Thu, 17 Jul 2014 02:35:54 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id cj8sm4830335wjb.5.2014.07.17.02.35.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jul 2014 02:35:53 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Thu, 17 Jul 2014 11:35:46 +0200 Message-ID: <2593913.gKODuJYKZP@xps13> Organization: 6WIND User-Agent: KMail/4.13.2 (Linux/3.15.5-1-ARCH; KDE/4.13.2; x86_64; ; ) In-Reply-To: <1404776219-6130-4-git-send-email-bruce.richardson@intel.com> References: <1404776219-6130-1-git-send-email-bruce.richardson@intel.com> <1404776219-6130-4-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/6] mk: Ensure correct detection of SSE4.2 on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jul 2014 09:34:59 -0000 Hi Bruce, 2014-07-08 00:36, Bruce Richardson: > Add a special case to the native target makefile, where we check if > -march=native shows SSE4.2 support. If it does not, then not everything may > build, so we check if the hardware supports SSE4.2, and use a corei7 target > explicitly to get the SSE4.2 support. [...] > MACHINE_CFLAGS = -march=native > + > +# on FreeBSD systems, sometimes the correct cputype is not picked up. > +# To get everything to compile, we need SSE4.2 support, so check if that is > +# reported by compiler. If not, check if the CPU actually supports it, and if > +# so, set the compilation target to be a corei7, minimum target with SSE4.2 > +SSE42_SUPPORT=$(shell $(CC) -march=native -dM -E - < /dev/null | grep SSE4_2) > +ifeq ($(SSE42_SUPPORT),) > + CPU_SSE42_SUPPORT=$(shell if [ -f /var/run/dmesg.boot ] ; then grep SSE4\.2 /var/run/dmesg.boot ; fi) > + ifneq ($(CPU_SSE42_SUPPORT),) > + MACHINE_CFLAGS= -march=corei7 > + endif > +endif What do you think of this change? - CPU_SSE42_SUPPORT=$(shell if [ -f /var/run/dmesg.boot ] ; then grep SSE4\.2 /var/run/dmesg.boot ; fi) + CPU_SSE42_SUPPORT = $(shell grep SSE4\.2 /var/run/dmesg.boot 2>/dev/null) It's simpler and should produce the same result. If you agree, I'll change it before applying. Thanks -- Thomas