From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A472AA09FD; Fri, 18 Dec 2020 12:27:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2866CAAB; Fri, 18 Dec 2020 12:27:16 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 8A7F8CAA7 for ; Fri, 18 Dec 2020 12:27:14 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 411895C00B5; Fri, 18 Dec 2020 06:27:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 18 Dec 2020 06:27:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Kjct9HKQqO0i+7i6YeoFkVHseTuYzlD/pFdeW0x9HXk=; b=nSmmY7762KjDZ4rn Z1LfDBZFUk4ovnFYFaBg7UoDEAG0CtYZsZR4Q2Ihf4fmo1Gu7qs/w1FbQhxEZqCA Fps1PavlGCwSrP90vjZCyYdBHCBwSftitvXvcmoQtXBR0yfdl7A85VN5XrMdCfEt j9M1WEzVbatlVDekQmqNEJMud6mOJVpqX8N5h2J48/Ce82+uLf9IMi9SWAs8wPKb Z0YenV7SQkhaDNzovQpbF0IfBCO0ui/Gn4MEXPAGTkJqHPid2MSFlRbXmNLYWpym 9slMhMcIb8WEqW7JXrb/rLIo4IZinpKJI5B000zSkVYjWrwQ70IqOTveDCtzCOZq p+ofVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Kjct9HKQqO0i+7i6YeoFkVHseTuYzlD/pFdeW0x9H Xk=; b=UOwOwAa5FtqbeO7XN5fOdSSU9PjNY15oNskktjrOgIb8x3Ut6FqBSCZiX xod44ebHMdnWiTLlndzsXki9U+NescdIEkT0uk2As/8OlfjrQvk33CVkE3a37z6x fFpegPY8euFj7N9x2Ng+gWKbD5QqFKzNIojJV1hyvPdj7/90InJjPLGYSKVx+Dko vo4MYR847g1NVTW4IpUVhauNl6eE47xa9Ii7yTekpJtCN9WmcvBy0T/AosNx3/VL 7fI+LMjtofAEof9sHKL/x28IcOmcV443dJB9ah6lyvHMYeZAQKFMjAbX8apiVldS rUy7Lu31/11QiTyF+oOsFX26QeWfg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeliedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrvddthedrudegfedruddtleenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (109.143.205.77.rev.sfr.net [77.205.143.109]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F6641080063; Fri, 18 Dec 2020 06:27:08 -0500 (EST) From: Thomas Monjalon To: Pallavi Kadam Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, bruce.richardson@intel.com, beilei.xing@intel.com, jia.guo@intel.com Date: Fri, 18 Dec 2020 12:27:05 +0100 Message-ID: <25941361.SrvSYD6x84@thomas> In-Reply-To: <20201217225909.3580-3-pallavi.kadam@intel.com> References: <20201205011020.6276-1-pallavi.kadam@intel.com> <20201217225909.3580-1-pallavi.kadam@intel.com> <20201217225909.3580-3-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: 17/12/2020 23:59, Pallavi Kadam: > Adds temp folder mlx5/windows as it is required to build this patch > without any build error. This folder will be removed once mlx5 PMD > patches are merged. Why is it required? > +if is_windows > + build = false > + reason = 'Not supported on Windows' > + subdir_done() > +endif As you can see in other files, the reason starts always with a lowercase letter. Please replace the first capital letter.