From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Flavio Leitner <fbl@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net: get rid of SET_ETHTOOL_OPS
Date: Wed, 02 Jul 2014 17:20:23 +0200 [thread overview]
Message-ID: <2595241.ncThof9bay@xps13> (raw)
In-Reply-To: <20140702130723.GU5631@t520.home>
2014-07-02 10:07, Flavio Leitner:
> On Wed, Jul 02, 2014 at 11:48:51AM +0200, Thomas Monjalon wrote:
> > You are removing SET_ETHTOOL_OPS calls.
>
> Yes.
>
> > In a previous patch, Aaro Koskinen made the choice to redefine the macro
> > in kcompat files.
>
> I missed that one.
>
> > I don't know what will be the choice of Intel in the sourceforge base
> > driver. So I've applied Aaro's patch as there are less modifications of
> > the base>
> > driver:
> > http://dpdk.org/browse/dpdk/commit/?id=e0b7ca0c0383411
>
> Since the macro is a simple pointer assignment, I didn't see any reason for
> keeping it around. But maybe I am missing something.
Me too. Except that this base driver is synchronized (sometimes) with the
sourceforge one. So we should try to minimize differences with it.
That's why I'd prefer that people managing the sourceforge codebase push their
patches here, or pull ours. But today, there is no rule.
Bonus game: who can find the commits of those projects?
http://sourceforge.net/projects/e1000
--
Thomas
prev parent reply other threads:[~2014-07-02 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 18:19 Flavio Leitner
2014-07-02 9:48 ` Thomas Monjalon
2014-07-02 13:07 ` Flavio Leitner
2014-07-02 15:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2595241.ncThof9bay@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=fbl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).