From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 0BA5458E1 for ; Wed, 2 Jul 2014 17:20:11 +0200 (CEST) Received: by mail-wi0-f171.google.com with SMTP id n15so9845900wiw.10 for ; Wed, 02 Jul 2014 08:20:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Wd3uxsN2omxRUUBsf9IKXrZpizGZmuh/hNFVpEW9qAw=; b=hH+0Bd/wWXdBr1lV0GfMW/T624oB3kJCzJCYB4njncHuVTt76dGgUwPw0VH9sekTFq dAzp63TyKU5laKt1jHa7vwMKIr2ftV+PILhyeZB9y15+9/iV6bZ1WDk6aBFyDUj2QU+9 nrG8SRZWiphkIA45EApiHhINo38tkn3Dr3U8/fX4UWzR6mTTH9GmSXe6IbrAowLWZSP/ R2oDtQ/c5Bt4REg4at6HYOAkl3HJa0Ufq+lCdQt/ox9Z3luthLn1Nsgs85RZu4ahxwX+ uYSbDF/4vgT1r87Ml7UVIbSWU03BwyXxppIqgA5WS3Iz9HpNqdFMRZEhXMa8GEvpgT8B wvUw== X-Gm-Message-State: ALoCoQk7MX9QY6DGI7aWTrPAa4fqrXcxBJ5aiBh+PyH0h1lSEeOwYUHGGsaDyNfWluUrUfYFA2nw X-Received: by 10.180.107.99 with SMTP id hb3mr5120131wib.8.1404314431475; Wed, 02 Jul 2014 08:20:31 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id bq7sm56232841wib.7.2014.07.02.08.20.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Jul 2014 08:20:30 -0700 (PDT) From: Thomas Monjalon To: Flavio Leitner Date: Wed, 02 Jul 2014 17:20:23 +0200 Message-ID: <2595241.ncThof9bay@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <20140702130723.GU5631@t520.home> References: <1404238780-19596-1-git-send-email-fbl@redhat.com> <5006516.KlozUPNl4J@xps13> <20140702130723.GU5631@t520.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net: get rid of SET_ETHTOOL_OPS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2014 15:20:11 -0000 2014-07-02 10:07, Flavio Leitner: > On Wed, Jul 02, 2014 at 11:48:51AM +0200, Thomas Monjalon wrote: > > You are removing SET_ETHTOOL_OPS calls. > > Yes. > > > In a previous patch, Aaro Koskinen made the choice to redefine the macro > > in kcompat files. > > I missed that one. > > > I don't know what will be the choice of Intel in the sourceforge base > > driver. So I've applied Aaro's patch as there are less modifications of > > the base> > > driver: > > http://dpdk.org/browse/dpdk/commit/?id=e0b7ca0c0383411 > > Since the macro is a simple pointer assignment, I didn't see any reason for > keeping it around. But maybe I am missing something. Me too. Except that this base driver is synchronized (sometimes) with the sourceforge one. So we should try to minimize differences with it. That's why I'd prefer that people managing the sourceforge codebase push their patches here, or pull ours. But today, there is no rule. Bonus game: who can find the commits of those projects? http://sourceforge.net/projects/e1000 -- Thomas